Skip to content

Commit 4b5cf4e

Browse files
ldenningtonvdye
authored andcommitted
release: move secrets to workflow environment (#584)
Migrate applicable secrets to a new 'release' workflow environment. This is a security measure to help ensure secrets cannot be accessed by those without proper permissions. An example of a passing `build-git-installers` workflow with these changes can be found [here](https://github.com/ldennington/git/actions/runs/5182147378) (I set up my fork with the same migrated secret values as this repo). Note that the old actions secrets will be left in this repo until the next successful release, at which point they can be safely removed.
2 parents 242474c + d202da3 commit 4b5cf4e

File tree

4 files changed

+9
-0
lines changed

4 files changed

+9
-0
lines changed

.github/workflows/build-git-installers.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ jobs:
99
# Check prerequisites for the workflow
1010
prereqs:
1111
runs-on: ubuntu-latest
12+
environment: release
1213
env:
1314
AZ_SUB: ${{ secrets.AZURE_SUBSCRIPTION }}
1415
AZ_CREDS: ${{ secrets.AZURE_CREDENTIALS }}
@@ -56,6 +57,7 @@ jobs:
5657
# Build Windows installers (x86_64 installer & portable)
5758
windows_pkg:
5859
runs-on: windows-2019
60+
environment: release
5961
needs: prereqs
6062
env:
6163
GPG_OPTIONS: "--batch --yes --no-tty --list-options no-show-photos --verify-options no-show-photos --pinentry-mode loopback"
@@ -151,6 +153,7 @@ jobs:
151153
path: artifacts
152154
windows_artifacts:
153155
runs-on: windows-2019
156+
environment: release
154157
needs: [prereqs, windows_pkg]
155158
env:
156159
HOME: "${{github.workspace}}\\home"
@@ -377,6 +380,7 @@ jobs:
377380
osx_sign_payload:
378381
# ESRP service requires signing to run on Windows
379382
runs-on: windows-latest
383+
environment: release
380384
needs: osx_build
381385
steps:
382386
- name: Check out repository
@@ -484,6 +488,7 @@ jobs:
484488
osx_sign_and_notarize_pkg:
485489
# ESRP service requires signing to run on Windows
486490
runs-on: windows-latest
491+
environment: release
487492
needs: osx_pack
488493
steps:
489494
- name: Check out repository
@@ -660,6 +665,7 @@ jobs:
660665
path: artifacts/
661666
ubuntu_sign-artifacts:
662667
runs-on: windows-latest # Must be run on Windows due to ESRP executable OS compatibility
668+
environment: release
663669
needs: [ubuntu_build, prereqs]
664670
if: needs.prereqs.outputs.deb_signable == 'true'
665671
env:

.github/workflows/release-apt-get.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ on:
1313
jobs:
1414
release:
1515
runs-on: ubuntu-latest
16+
environment: release
1617
steps:
1718
- uses: actions/checkout@v3
1819

.github/workflows/release-homebrew.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
jobs:
77
release:
88
runs-on: ubuntu-latest
9+
environment: release
910
steps:
1011
- id: version
1112
name: Compute version number

.github/workflows/release-winget.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ on:
1313
jobs:
1414
release:
1515
runs-on: windows-latest
16+
environment: release
1617
steps:
1718
- name: Publish manifest with winget-create
1819
run: |

0 commit comments

Comments
 (0)