Merge pull request #1490 from microsoft/upd-251201

Updates for 2025-12-01

Author: jeffwilcox

.config/.markdownlint-cli2.jsonc

@@ -9,6 +9,7 @@
     "MD033": false
   },
   "ignores": [
+    ".github/prompts/**",
     "**/node_modules/**",
     "frontend/**",
     "microsoft/assets/**",

.github/copilot-instructions.md

@@ -505,7 +505,6 @@
         "DEBUG": "redis,restapi,startup,appinsights"
       }
     },
-
     {
       "type": "node",
       "request": "launch",

.vscode/launch.json

@@ -10,7 +10,6 @@ const router: Router = Router();
 
 import { getProviders } from '../../lib/transitional.js';
 import { jsonError } from '../../middleware/jsonError.js';
-import { IndividualContext } from '../../business/user/index.js';
 import { Organization } from '../../business/organization.js';
 import {
   createRepositoryCore,
@@ -24,6 +23,7 @@ import {
   ReposAppRequest,
   VoidedExpressRoute,
 } from '../../interfaces/index.js';
+import type { IndividualContext } from '../../business/user/index.js';
 
 // This file supports the client apps for creating repos.
 
@@ -451,13 +451,12 @@ export async function createRepositoryFromClient(
     title: existingRepoId ? 'Repository unlocked' : 'Repository created',
     message,
     url: null,
-    messages: null,
+    messages: success.tasks,
   };
+  delete output.tasks;
   if (success.github) {
     output.url = success.github.html_url;
   }
-  output.messages = output['tasks'];
-  delete output['tasks'];
   insights.trackEvent({
     name: 'ApiClientNewOrgRepoSuccessful',
     properties: {

api/client/newOrgRepo.ts

@@ -72,7 +72,7 @@ export interface ICreateRepositoryApiResult {
   repositoryId: number;
   organizationName: string;
   notified?: string[];
-  tasks?: any[];
+  tasks?: IRepositoryWorkflowOutput[];
 }
 
 export type CreateRepositoryMicrosoftProperties = {
@@ -415,7 +415,7 @@ export async function createRepositoryCore(
   };
   // req.approvalRequest['ms.approvalId'] = requestId; // TODO: is this ever used?
   const repoWorkflow = new RepoWorkflowEngine(providers, organization, repository, approvalPackage);
-  let output = [];
+  let output: IRepositoryWorkflowOutput[] = [];
   try {
     output = await generateAndRunSecondaryTasks(repoWorkflow);
   } catch (rollbackNeededError) {

api/createRepo.ts

@@ -29,23 +29,39 @@ import type { CreateRepositoryRequest } from './client/newOrgRepo.js';
 
 const hardcodedApiVersions = ['2019-10-01', '2019-02-01', '2017-09-01', '2017-03-08', '2016-12-01'];
 
+const MOST_RECENT_VERSION = hardcodedApiVersions[0];
+const CLIENT_ROUTE_PREFIX = '/client';
+
+function skipApiVersionCheck(req: ReposAppRequest, prefixes: string[]) {
+  for (const prefix of prefixes) {
+    if (req.path.startsWith(prefix)) {
+      return true;
+    }
+  }
+  return false;
+}
+
 function isClientRoute(req: ReposAppRequest) {
-  const path = req.path.toLowerCase();
-  return path.startsWith('/client');
+  return req.path.startsWith(CLIENT_ROUTE_PREFIX);
 }
 
 export default function routeApi(config: SiteConfiguration) {
   if (!config) {
     throw CreateError.InvalidParameters('No configuration provided to the API routes');
   }
+  const companySpecificDeployment = getCompanySpecificDeployment();
+  const skipApiVersionChecksForPrefixes =
+    companySpecificDeployment?.routes?.api?.skipApiVersionChecksForPrefixes || [];
+  const combinedSkipVersionPrefixes = [CLIENT_ROUTE_PREFIX, ...skipApiVersionChecksForPrefixes];
 
   router.use('/webhook', apiWebhook);
 
   router.use((req: ReposApiRequest, res: Response, next: NextFunction) => {
-    if (isClientRoute(req)) {
+    if (skipApiVersionCheck(req, combinedSkipVersionPrefixes)) {
       // The frontend client routes are hooked into Express after
       // the session middleware. The client route does not require
-      // an API version.
+      // an API version. Also, some APIs do not require a version.
+      req.apiVersion = MOST_RECENT_VERSION;
       return next();
     }
     const apiVersion = (req.query['api-version'] || req.headers['api-version']) as string;

api/index.ts

@@ -3,7 +3,6 @@
 // Licensed under the MIT license. See LICENSE file in the project root for full license information.
 //
 
-import GitHubEnterpriseCopilot from './enterpriseCopilot.js';
 import { GitHubTokenType, getGitHubTokenTypeFromValue } from '../lib/github/appTokens.js';
 import { CreateError } from '../lib/transitional.js';
 import { createPagedCacheOptions, getPageSize, symbolizeApiResponse } from './operations/core.js';
@@ -14,6 +13,7 @@ import type {
   IPagedCacheOptions,
   IProviders,
 } from '../interfaces/index.js';
+import GitHubEnterpriseBilling from './enterpriseBilling.js';
 
 // TODO: paginate across enterprise fix + support iterators
 
@@ -98,7 +98,7 @@ function isStringToken(token: string | GetAuthorizationHeader): token is string
 }
 
 export default class GitHubEnterprise {
-  private _copilot: GitHubEnterpriseCopilot;
+  private _billing: GitHubEnterpriseBilling;
   private _graphqlNodeId: string;
 
   constructor(
@@ -138,15 +138,21 @@ export default class GitHubEnterprise {
   }
 
   get copilot() {
-    if (!this._copilot) {
+    throw CreateError.NotImplemented(
+      'GitHub Copilot use APIs are not published to the open source project currently.'
+    );
+  }
+
+  get billing() {
+    if (!this._billing) {
       if (!isStringToken(this.enterpriseToken)) {
         throw CreateError.InvalidParameters(
-          'Copilot APIs currently require a string token. Please use a separate instance.'
+          'Billing APIs currently require a string token. Please use a separate instance.'
         );
       }
-      this._copilot = new GitHubEnterpriseCopilot(this.providers, this, this.enterpriseToken);
+      this._billing = new GitHubEnterpriseBilling(this.providers, this, this.enterpriseToken);
     }
-    return this._copilot;
+    return this._billing;
   }
 
   async getId(): Promise<string> {