Skip to content

Commit 1e1d182

Browse files
committed
Proper selector.register callback
1 parent 25aa857 commit 1e1d182

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

tests/async/test_selectors_misc.py

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,19 @@ async def test_should_work_with_internal_and(page: Page) -> None:
6161
async def test_should_throw_already_registered_error_when_registering(
6262
selectors: Selectors,
6363
) -> None:
64-
await selectors.register("alreadyRegistered", "return []")
64+
create_tag_selector = """
65+
() => ({
66+
query(root, selector) {
67+
return root.querySelector(selector);
68+
},
69+
queryAll(root, selector) {
70+
return Array.from(root.querySelectorAll(selector));
71+
}
72+
});
73+
"""
74+
await selectors.register("alreadyRegistered", create_tag_selector)
6575
with pytest.raises(
6676
Error,
6777
match='Selectors.register: "alreadyRegistered" selector engine has been already registered',
6878
):
69-
await selectors.register("alreadyRegistered", "return []")
79+
await selectors.register("alreadyRegistered", create_tag_selector)

0 commit comments

Comments
 (0)