Ensure send() method uses drain() to handle writes correctly #2759
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
send()method to ensure it properly queues data when a write operation fails and usesdrain()to handle writes efficiently.Changes
await self._output.drain()after writing data to ensure the write operation is properly flushed.asynciousage pattern.I opened this PR because the asyncio documentation recommends using
drain()when writing to a stream. This ensures that writes are properly handled without blocking or data loss, making it a best practice for managing asynchronous I/O.