Skip to content

Restart icon is not themeable #16118

@miguelsolorio

Description

@miguelsolorio

Applies To

  • Notebooks (.ipynb files)
  • Interactive Window and/or Cell Scripts (.py files with #%% markers)

What happened?

Nit: toolbar is contributing an SVG that is not themeable and stands out in themes:

Image

Suggestion to remove this icon path:

vscode-jupyter/package.json

Lines 602 to 605 in 4a13fca

"icon": {
"light": "resources/light/restart-kernel.svg",
"dark": "resources/dark/restart-kernel.svg"
},

and replace with using native icons:

"icon": "$(restart)"

This also allows product icon themes to customize this icon & color:

Image

Version: 1.94.2
Commit: 384ff7382de624fb94dbaf6da11977bba1ecd427
Date: 2024-10-09T16:08:44.566Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Code/1.94.2 Chrome/124.0.6367.243 Electron/30.5.1 Safari/537.36

VS Code Version

1.94.2

Jupyter Extension Version

v2024.9.1

Jupyter logs

No response

Coding Language and Runtime Version

No response

Language Extension Version (if applicable)

No response

Anaconda Version (if applicable)

No response

Running Jupyter locally or remotely?

None

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugnotebook-toolbar

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions