diff --git a/.github/workflows/src/summarize-checks/summarize-checks.js b/.github/workflows/src/summarize-checks/summarize-checks.js index e345861751f0..d4c98567e726 100644 --- a/.github/workflows/src/summarize-checks/summarize-checks.js +++ b/.github/workflows/src/summarize-checks/summarize-checks.js @@ -19,12 +19,12 @@ */ // #region imports/constants -import { extractInputs } from "../context.js"; -// import { commentOrUpdate } from "../comment.js"; import { execFile } from "../../../shared/src/exec.js"; import { CheckConclusion, PER_PAGE_MAX } from "../../../shared/src/github.js"; import { intersect } from "../../../shared/src/set.js"; import { byDate, invert } from "../../../shared/src/sort.js"; +import { commentOrUpdate } from "../comment.js"; +import { extractInputs } from "../context.js"; import { brChRevApproval, getViolatedRequiredLabelsRules, @@ -141,7 +141,8 @@ const FYI_CHECK_NAMES = [ "Swagger BreakingChange", "Swagger PrettierCheck", ]; -const AUTOMATED_CHECK_NAME = "[TEST-IGNORE] Automated merging requirements met"; +const AUTOMATED_CHECK_NAME = "Automated merging requirements met"; +const IMPACT_CHECK_NAME = "Summarize PR Impact"; const NEXT_STEPS_COMMENT_ID = "NextStepsToMerge"; /** @type {CheckMetadata[]} */ @@ -403,24 +404,24 @@ export async function summarizeChecksImpl( for (const label of labelContext.toRemove) { core.info(`Removing label: ${label} from ${owner}/${repo}#${issue_number}.`); - // await github.rest.issues.removeLabel({ - // owner: owner, - // repo: repo, - // issue_number: issue_number, - // name: label, - // }); + await github.rest.issues.removeLabel({ + owner: owner, + repo: repo, + issue_number: issue_number, + name: label, + }); } if (labelContext.toAdd.size > 0) { core.info( `Adding labels: ${Array.from(labelContext.toAdd).join(", ")} to ${owner}/${repo}#${issue_number}.`, ); - // await github.rest.issues.addLabels({ - // owner: owner, - // repo: repo, - // issue_number: issue_number, - // labels: Array.from(labelContext.toAdd), - // }); + await github.rest.issues.addLabels({ + owner: owner, + repo: repo, + issue_number: issue_number, + labels: Array.from(labelContext.toAdd), + }); } // adjust labelNames based on labelsToAdd/labelsToRemove @@ -451,20 +452,21 @@ export async function summarizeChecksImpl( core.summary.write(); // this will remain commented until we're comfortable with the change. - // await commentOrUpdate( - // { github, context, core }, - // owner, - // repo, - // issue_number, - // commentName, - // commentBody - // ) + await commentOrUpdate( + github, + core, + owner, + repo, + issue_number, + commentBody, + NEXT_STEPS_COMMENT_ID, + ); // finally, update the "Automated merging requirements met" commit status await updateCommitStatus(github, core, owner, repo, head_sha, automatedChecksMet); core.info( - `Summarize checks has identified that status of "[TEST-IGNORE] Automated merging requirements met" commit status should be updated to: ${JSON.stringify(automatedChecksMet)}.`, + `Summarize checks has identified that status of "${AUTOMATED_CHECK_NAME}" commit status should be updated to: ${JSON.stringify(automatedChecksMet)}.`, ); core.summary.addHeading("Automated Checks Met", 2); core.summary.addCodeBlock(JSON.stringify(automatedChecksMet, null, 2)); @@ -517,9 +519,6 @@ export async function updateCommitStatus(github, core, owner, repo, head_sha, ch * @param {string} owner * @param {string} repo * @param {number} issue_number - * @param {*} owner - * @param {*} repo - * @param {*} issue_number * @return {Promise} */ export async function getExistingLabels(github, owner, repo, issue_number) { @@ -731,10 +730,8 @@ export async function getCheckRunTuple( const latestCheck = sortedChecks[0]; - // just handling both names for ease of integration testing if ( - (latestCheck.name === "[TEST-IGNORE] Summarize PR Impact" || - latestCheck.name === "Summarize PR Impact") && + latestCheck.name === IMPACT_CHECK_NAME && latestCheck.status === "completed" && latestCheck.conclusion === "success" ) { @@ -805,7 +802,7 @@ export async function getCheckRunTuple( ); } } else { - requiredCheckNames = ["Summarize PR Impact", "[TEST-IGNORE] Summarize PR Impact"]; + requiredCheckNames = [IMPACT_CHECK_NAME]; } const filteredReqCheckRuns = unifiedCheckRuns.filter( diff --git a/.github/workflows/summarize-checks.yaml b/.github/workflows/summarize-checks.yaml index f14cb519bb94..42b418ae45b1 100644 --- a/.github/workflows/summarize-checks.yaml +++ b/.github/workflows/summarize-checks.yaml @@ -1,11 +1,11 @@ -name: "[TEST-IGNORE] Summarize Checks" +name: "Summarize Checks" on: workflow_run: workflows: - - "\\[TEST-IGNORE\\] Swagger SemanticValidation - Set Status" - - "\\[TEST-IGNORE\\] Swagger ModelValidation - Set Status" - - "\\[TEST-IGNORE\\] Summarize PR Impact" + - "Swagger SemanticValidation - Set Status" + - "Swagger ModelValidation - Set Status" + - "Summarize PR Impact" - "Swagger Avocado - Set Status" - "Swagger LintDiff - Set Status" - "SDK Validation Status" @@ -34,7 +34,7 @@ permissions: jobs: run-summarize-checks: if: ${{ github.event_name == 'pull_request_target' || github.event.workflow_run.conclusion != 'skipped' }} - name: "[TEST-IGNORE] Summarize Checks" + name: "Summarize Checks" runs-on: ubuntu-24.04 steps: diff --git a/.github/workflows/summarize-impact.yaml b/.github/workflows/summarize-impact.yaml index d113b5fe3045..6bafe8e84454 100644 --- a/.github/workflows/summarize-impact.yaml +++ b/.github/workflows/summarize-impact.yaml @@ -1,4 +1,4 @@ -name: "[TEST-IGNORE] Summarize PR Impact" +name: "Summarize PR Impact" on: pull_request: @@ -16,7 +16,7 @@ permissions: jobs: impact: - name: "[TEST-IGNORE] Summarize PR Impact" + name: "Summarize PR Impact" runs-on: ubuntu-24.04 steps: diff --git a/.github/workflows/swagger-modelvalidation-code.yaml b/.github/workflows/swagger-modelvalidation-code.yaml index 097ce8073a94..5406e0b124dd 100644 --- a/.github/workflows/swagger-modelvalidation-code.yaml +++ b/.github/workflows/swagger-modelvalidation-code.yaml @@ -1,4 +1,4 @@ -name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code" +name: "Swagger ModelValidation - Analyze Code" on: pull_request @@ -7,7 +7,7 @@ permissions: jobs: oav: - name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code" + name: "Swagger ModelValidation - Analyze Code" runs-on: ubuntu-24.04 steps: diff --git a/.github/workflows/swagger-modelvalidation-status.yaml b/.github/workflows/swagger-modelvalidation-status.yaml index 7310b1c94f6e..3f76adb23fd1 100644 --- a/.github/workflows/swagger-modelvalidation-status.yaml +++ b/.github/workflows/swagger-modelvalidation-status.yaml @@ -1,4 +1,4 @@ -name: "[TEST-IGNORE] Swagger ModelValidation - Set Status" +name: "Swagger ModelValidation - Set Status" on: # Must run on pull_request_target instead of pull_request, since the latter cannot trigger on @@ -15,7 +15,7 @@ on: - labeled - unlabeled workflow_run: - workflows: ["\\[TEST-IGNORE\\] Swagger ModelValidation - Analyze Code"] + workflows: ["Swagger ModelValidation - Analyze Code"] types: [completed] permissions: @@ -30,6 +30,6 @@ jobs: name: Set ModelValidation Status uses: ./.github/workflows/_reusable-set-check-status.yaml with: - monitored_workflow_name: "[TEST-IGNORE] Swagger ModelValidation - Analyze Code" - required_check_name: "[TEST-IGNORE] Swagger ModelValidation" + monitored_workflow_name: "Swagger ModelValidation - Analyze Code" + required_check_name: "Swagger ModelValidation" overriding_label: "Approved-ModelValidation" diff --git a/.github/workflows/swagger-semanticvalidation-code.yaml b/.github/workflows/swagger-semanticvalidation-code.yaml index e7d492127eaf..63665dbed1f7 100644 --- a/.github/workflows/swagger-semanticvalidation-code.yaml +++ b/.github/workflows/swagger-semanticvalidation-code.yaml @@ -1,4 +1,4 @@ -name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code" +name: "Swagger SemanticValidation - Analyze Code" on: pull_request @@ -7,7 +7,7 @@ permissions: jobs: oav: - name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code" + name: "Swagger SemanticValidation - Analyze Code" runs-on: ubuntu-24.04 steps: diff --git a/.github/workflows/swagger-semanticvalidation-status.yaml b/.github/workflows/swagger-semanticvalidation-status.yaml index 1166cb44ba20..62f432524f17 100644 --- a/.github/workflows/swagger-semanticvalidation-status.yaml +++ b/.github/workflows/swagger-semanticvalidation-status.yaml @@ -1,4 +1,4 @@ -name: "[TEST-IGNORE] Swagger SemanticValidation - Set Status" +name: "Swagger SemanticValidation - Set Status" on: # Must run on pull_request_target instead of pull_request, since the latter cannot trigger on @@ -15,7 +15,7 @@ on: - labeled - unlabeled workflow_run: - workflows: ["\\[TEST-IGNORE\\] Swagger SemanticValidation - Analyze Code"] + workflows: ["Swagger SemanticValidation - Analyze Code"] types: [completed] permissions: @@ -30,6 +30,6 @@ jobs: name: Set SemanticValidation Status uses: ./.github/workflows/_reusable-set-check-status.yaml with: - monitored_workflow_name: "[TEST-IGNORE] Swagger SemanticValidation - Analyze Code" - required_check_name: "[TEST-IGNORE] Swagger SemanticValidation" + monitored_workflow_name: "Swagger SemanticValidation - Analyze Code" + required_check_name: "Swagger SemanticValidation" overriding_label: "Approved-SemanticValidation" diff --git a/.github/workflows/test/set-status.test.js b/.github/workflows/test/set-status.test.js index 26d506caa4fa..f1d0c6341f76 100644 --- a/.github/workflows/test/set-status.test.js +++ b/.github/workflows/test/set-status.test.js @@ -72,8 +72,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger Avocado - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger Avocado", + monitoredWorkflowName: "Swagger Avocado - Analyze Code", + requiredStatusName: "Swagger Avocado", overridingLabel: "Approved-Avocado", }), ).resolves.toBeUndefined(); @@ -83,7 +83,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: CommitStatusState.SUCCESS, - context: "[TEST-IGNORE] Swagger Avocado", + context: "Swagger Avocado", description: "Found label 'Approved-Avocado'", target_url: "https://test.com/set_status_url", }); @@ -103,8 +103,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange", + monitoredWorkflowName: "Swagger BreakingChange - Analyze Code", + requiredStatusName: "Swagger BreakingChange", overridingLabel: "BreakingChange-Approved-Benign,BreakingChange-Approved-BugFix,BreakingChange-Approved-UserImpact", }), @@ -115,7 +115,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: CommitStatusState.SUCCESS, - context: "[TEST-IGNORE] Swagger BreakingChange", + context: "Swagger BreakingChange", description: "Found label 'BreakingChange-Approved-Benign'", target_url: "https://test.com/set_status_url", }); @@ -138,8 +138,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange", + monitoredWorkflowName: "Swagger BreakingChange - Analyze Code", + requiredStatusName: "Swagger BreakingChange", overridingLabel: "BreakingChange-Approved-Benign, BreakingChange-Approved-BugFix , BreakingChange-Approved-UserImpact", }), @@ -150,7 +150,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: CommitStatusState.SUCCESS, - context: "[TEST-IGNORE] Swagger BreakingChange", + context: "Swagger BreakingChange", description: "Found label 'BreakingChange-Approved-UserImpact'", target_url: "https://test.com/set_status_url", }); @@ -170,8 +170,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange", + monitoredWorkflowName: "Swagger BreakingChange - Analyze Code", + requiredStatusName: "Swagger BreakingChange", overridingLabel: "BreakingChange-Approved-Benign,,BreakingChange-Approved-Security,", }), ).resolves.toBeUndefined(); @@ -181,7 +181,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: CommitStatusState.SUCCESS, - context: "[TEST-IGNORE] Swagger BreakingChange", + context: "Swagger BreakingChange", description: "Found label 'BreakingChange-Approved-Security'", target_url: "https://test.com/set_status_url", }); @@ -205,8 +205,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange", + monitoredWorkflowName: "Swagger BreakingChange - Analyze Code", + requiredStatusName: "Swagger BreakingChange", overridingLabel: "BreakingChange-Approved-Benign,BreakingChange-Approved-BugFix,BreakingChange-Approved-UserImpact", }), @@ -217,7 +217,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: CommitStatusState.PENDING, - context: "[TEST-IGNORE] Swagger BreakingChange", + context: "Swagger BreakingChange", target_url: "https://test.com/set_status_url", }); }); @@ -240,8 +240,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger BreakingChange - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger BreakingChange", + monitoredWorkflowName: "Swagger BreakingChange - Analyze Code", + requiredStatusName: "Swagger BreakingChange", overridingLabel: "", }), ).resolves.toBeUndefined(); @@ -251,7 +251,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: CommitStatusState.PENDING, - context: "[TEST-IGNORE] Swagger BreakingChange", + context: "Swagger BreakingChange", target_url: "https://test.com/set_status_url", }); }); @@ -294,7 +294,7 @@ describe("setStatusImpl", () => { github.rest.actions.listWorkflowRunsForRepo.mockResolvedValue({ data: [ { - name: "[TEST-IGNORE] Swagger Avocado - Analyze Code", + name: "Swagger Avocado - Analyze Code", status: checkStatus, conclusion: checkConclusion, updated_at: "2025-01-01", @@ -333,8 +333,8 @@ describe("setStatusImpl", () => { target_url: "https://test.com/set_status_url", github, core, - monitoredWorkflowName: "[TEST-IGNORE] Swagger Avocado - Analyze Code", - requiredStatusName: "[TEST-IGNORE] Swagger Avocado", + monitoredWorkflowName: "Swagger Avocado - Analyze Code", + requiredStatusName: "Swagger Avocado", overridingLabel: "Approved-Avocado", }), ).resolves.toBeUndefined(); @@ -344,7 +344,7 @@ describe("setStatusImpl", () => { repo: "test-repo", sha: fullGitSha, state: commitStatusState, - context: "[TEST-IGNORE] Swagger Avocado", + context: "Swagger Avocado", target_url: targetUrl, }); }, diff --git a/.github/workflows/test/summarize-checks/summarize-checks.test.js b/.github/workflows/test/summarize-checks/summarize-checks.test.js index 24fb92b9a582..9b48189841e8 100644 --- a/.github/workflows/test/summarize-checks/summarize-checks.test.js +++ b/.github/workflows/test/summarize-checks/summarize-checks.test.js @@ -129,7 +129,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ '

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.', { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "SUCCESS", summary: `✅ All automated merging requirements have been met.
To merge this PR, refer to aka.ms/azsdk/specreview/merge.
For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`, }, @@ -157,7 +157,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ '

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.', { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "SUCCESS", summary: `✅ All automated merging requirements have been met.
To merge this PR, refer to aka.ms/azsdk/specreview/merge.
For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`, }, @@ -265,7 +265,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ '

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.', { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "SUCCESS", summary: `✅ All automated merging requirements have been met.
To merge this PR, refer to aka.ms/azsdk/specreview/merge.
For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`, }, @@ -337,7 +337,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ '

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.', { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "SUCCESS", summary: `✅ All automated merging requirements have been met.
To merge this PR, refer to aka.ms/azsdk/specreview/merge.
For help, consult comments on this PR and see [aka.ms/azsdk/pr-getting-help](https://aka.ms/azsdk/pr-getting-help).`, }, @@ -393,7 +393,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ `

Next Steps to Merge

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:
If you still want to proceed merging this PR without addressing the above failures, refer to step 4 in the PR workflow diagram.

Comment generated by summarize-checks workflow run.`, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "SUCCESS", summary: `⚠️ Some important automated merging requirements have failed. As of today you can still merge this PR, but soon these requirements will be blocking.
See Next Steps to merge comment on this PR for details on how to address them.
If you want to proceed with merging this PR without fixing them, refer to aka.ms/azsdk/specreview/merge.`, }, @@ -438,7 +438,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ `

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.`, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "pending", summary: "The requirements for merging this PR are still being evaluated. Please wait.", }, @@ -487,7 +487,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ `

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.`, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "pending", summary: "The requirements for merging this PR are still being evaluated. Please wait.", }, @@ -536,7 +536,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ `

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.`, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "pending", summary: "The requirements for merging this PR are still being evaluated. Please wait.", }, @@ -645,7 +645,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ `

Next Steps to Merge

⌛ Please wait. Next steps to merge this PR are being evaluated by automation. ⌛

Comment generated by summarize-checks workflow run.`, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "pending", summary: "The requirements for merging this PR are still being evaluated. Please wait.", }, @@ -719,7 +719,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ `

Next Steps to Merge

Important checks have failed. As of today they are not blocking this PR, but in near future they may.
Addressing the following failures is highly recommended:


Comment generated by summarize-checks workflow run.`, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "pending", summary: "The requirements for merging this PR are still being evaluated. Please wait.", }, @@ -924,7 +924,7 @@ describe("Summarize Checks Unit Tests", () => { const expectedOutput = [ expectedComment, { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "FAILURE", summary: "❌ This PR cannot be merged because some requirements are not met. See the details.", @@ -1031,7 +1031,7 @@ describe("Summarize Checks Unit Tests", () => { const targetBranch = "main"; const labelNames = []; const expectedCheckOutput = { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "FAILURE", summary: "❌ This PR cannot be merged because some requirements are not met. See the details.", @@ -1076,7 +1076,7 @@ describe("Summarize Checks Unit Tests", () => { const targetBranch = "main"; const labelNames = []; const expectedCheckOutput = { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "FAILURE", summary: "❌ This PR cannot be merged because some requirements are not met. See the details.", @@ -1119,7 +1119,7 @@ describe("Summarize Checks Unit Tests", () => { const labelNames = []; const fyiCheckRuns = []; const expectedCheckOutput = { - name: "[TEST-IGNORE] Automated merging requirements met", + name: "Automated merging requirements met", result: "FAILURE", summary: "❌ This PR cannot be merged because some requirements are not met. See the details.", diff --git a/.github/workflows/watch-modelvalidation.yaml b/.github/workflows/watch-modelvalidation.yaml deleted file mode 100644 index ba3ff8165018..000000000000 --- a/.github/workflows/watch-modelvalidation.yaml +++ /dev/null @@ -1,27 +0,0 @@ -# Use ~ to sort the workflow to the bottom of the list -name: "~Watch - Swagger ModelValidation" - -on: - # check_suite is preferred over check_run to avoid triggering on all check - # runs. In some cases, check_run must be used in testing environments. - check_suite: - types: completed - - workflow_run: - types: completed - workflows: - - "\\[TEST-IGNORE\\] Swagger ModelValidation" - -permissions: - actions: read - checks: read - contents: read - statuses: read - -jobs: - ModelValidationWatch: - name: Watch ModelValidation - uses: ./.github/workflows/_reusable-verify-run-status.yaml - with: - check_run_name: "Swagger ModelValidation" - workflow_name: "[TEST-IGNORE] Swagger ModelValidation" diff --git a/.github/workflows/watch-semanticvalidation.yaml b/.github/workflows/watch-semanticvalidation.yaml deleted file mode 100644 index 757e55e367d6..000000000000 --- a/.github/workflows/watch-semanticvalidation.yaml +++ /dev/null @@ -1,27 +0,0 @@ -# Use ~ to sort the workflow to the bottom of the list -name: "~Watch - Swagger SemanticValidation" - -on: - # check_suite is preferred over check_run to avoid triggering on all check - # runs. In some cases, check_run must be used in testing environments. - check_suite: - types: completed - - workflow_run: - types: completed - workflows: - - "\\[TEST-IGNORE\\] Swagger SemanticValidation" - -permissions: - actions: read - checks: read - contents: read - statuses: read - -jobs: - SemanticValidationWatch: - name: Watch SemanticValidation - uses: ./.github/workflows/_reusable-verify-run-status.yaml - with: - check_run_name: "Swagger SemanticValidation" - workflow_name: "[TEST-IGNORE] Swagger SemanticValidation" diff --git a/specification/widget/resource-manager/Microsoft.Widget/Widget/employee.tsp b/specification/widget/resource-manager/Microsoft.Widget/Widget/employee.tsp index 3c5e47132d00..1a5755ee9138 100644 --- a/specification/widget/resource-manager/Microsoft.Widget/Widget/employee.tsp +++ b/specification/widget/resource-manager/Microsoft.Widget/Widget/employee.tsp @@ -18,7 +18,7 @@ model Employee is TrackedResource { /** Employee properties */ model EmployeeProperties { /** Age of employee */ - age?: int32; + age?: int64; /** City of employee */ city?: string; diff --git a/specification/widget/resource-manager/Microsoft.Widget/Widget/preview/2021-10-01-preview/widget.json b/specification/widget/resource-manager/Microsoft.Widget/Widget/preview/2021-10-01-preview/widget.json index 2f9c53a6f691..19153c48bcf4 100644 --- a/specification/widget/resource-manager/Microsoft.Widget/Widget/preview/2021-10-01-preview/widget.json +++ b/specification/widget/resource-manager/Microsoft.Widget/Widget/preview/2021-10-01-preview/widget.json @@ -472,7 +472,7 @@ "properties": { "age": { "type": "integer", - "format": "int32", + "format": "int64", "description": "Age of employee" }, "city": { diff --git a/specification/widget/resource-manager/Microsoft.Widget/Widget/stable/2021-11-01/widget.json b/specification/widget/resource-manager/Microsoft.Widget/Widget/stable/2021-11-01/widget.json index 99d6cc8187b6..e6548941e496 100644 --- a/specification/widget/resource-manager/Microsoft.Widget/Widget/stable/2021-11-01/widget.json +++ b/specification/widget/resource-manager/Microsoft.Widget/Widget/stable/2021-11-01/widget.json @@ -472,7 +472,7 @@ "properties": { "age": { "type": "integer", - "format": "int32", + "format": "int64", "description": "Age of employee" }, "city": {