Skip to content

s5 aspect not working #93

@candlerb

Description

@candlerb

I have been trying to get the s5 aspect working in the 0.9.15 gem.

First thing was to symlink plugins/filters/s5/ui to a checkout of diascope

cd
git checkout git://github.com/minad/diascope.git
sudo mv diascope /usr/local/share/
sudo ln -s /usr/local/share/diascope/ui /var/lib/gems/1.9.1/gems/olelo-0.9.15/plugins/filters/s5/ui

After this the s5 aspect is available, but it doesn't render properly. Looking at the logs, the page is asking for e.g.

/_/assets/filter/s5/ui/common/jquery.js
whereas it should be
/_/assets/filters/s5/ui/common/jquery.js (note: filters not filter)

So I tried making what I thought was the obvious fix:

--- plugins/filters/s5/main.rb.orig     2013-08-29 23:39:41.642937172 +0100
+++ plugins/filters/s5/main.rb  2013-08-29 23:40:01.226936167 +0100
@@ -27,7 +27,7 @@
     themes.delete('default')
     themes.unshift(context.page.attributes['theme'] || 'default')
     super.merge(context.page.attributes['s5'] || {}).
-      merge('themes' => themes.join(' '), 's5_path' => build_path('_/assets/filter/s5'))
+      merge('themes' => themes.join(' '), 's5_path' => build_path('_/assets/filters/s5'))
   end
 end

However even after a server restart, I see requests for /assets/filter/s5. Something is cached somewhere. In fact, if I edit plugins/filters/s5/main.rb and put some debugging in, I don't think S5#params is being called at all.

I'm a bit lost now as to where the problem is.

Also: at http://www.gitwiki.org/Tests/Slideshow I note the comment "Still some stuff to fix here" which suggests there is some underlying issue...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions