WMSDK-445: review

Author: sozinov

android/src/main/java/com/mindboxsdk/MindboxEventEmitter.kt

@@ -18,11 +18,11 @@ internal class MindboxEventEmitter (
 
     private var jsDelivery: MindboxJsDelivery? = null
 
-    override fun onEvent(event: MindboxSdkLifecyceEvent) {
+    override fun onEvent(event: MindboxSdkLifecycleEvent) {
         when (event) {
-            is MindboxSdkLifecyceEvent.NewIntent -> handleNewIntent(event.reactContext, event.intent)
-            is MindboxSdkLifecyceEvent.ActivityCreated -> handleActivityCreated(event.reactContext, event.activity)
-            is MindboxSdkLifecyceEvent.ActivityDestroyed -> handleActivityDestroyed()
+            is MindboxSdkLifecycleEvent.NewIntent -> handleNewIntent(event.reactContext, event.intent)
+            is MindboxSdkLifecycleEvent.ActivityCreated -> handleActivityCreated(event.reactContext, event.activity)
+            is MindboxSdkLifecycleEvent.ActivityDestroyed -> handleActivityDestroyed()
         }
     }
 

android/src/main/java/com/mindboxsdk/MindboxSdkInitProvider.kt

@@ -16,17 +16,17 @@ internal class MindboxSdkInitProvider : ContentProvider() {
 
     override fun onCreate(): Boolean {
         runCatching {
-            Log.d("Test", "onCreate initProvider.")
+            Log.i("MindboxSdkInitProvider", "onCreate initProvider.")
             (context?.applicationContext as? Application)?.let { application ->
                 if (isAutoInitEnabled(application)) {
-                    Log.d("Test", "Automatic initialization is enabled.")
+                    Log.i("MindboxSdkInitProvider", "Automatic initialization is enabled.")
                     MindboxSdkLifecycleListener.register(application)
                 } else {
-                    Log.d("Test", "Automatic initialization is disabled.")
+                    Log.i("MindboxSdkInitProvider", "Automatic initialization is disabled.")
                 }
             }
         }.onFailure { error ->
-            Log.e("Test", "Automatic initialization failed", error)
+            Log.e("MindboxSdkInitProvider", "Automatic initialization failed", error)
         }
         return true
     }
@@ -39,7 +39,7 @@ internal class MindboxSdkInitProvider : ContentProvider() {
             )
             appInfo.metaData
                 ?.getBoolean(AUTO_INIT_ENABLED_KEY, false)
-                ?.also { Log.d("Mindbox", "Result of reading mindbox metadata is $it") }
+                ?.also { Log.i("Mindbox", "Result of reading mindbox metadata is $it") }
                 ?: false
         }.getOrElse { false }
 

android/src/main/java/com/mindboxsdk/MindboxSdkLifecycleEvent.kt

@@ -4,8 +4,8 @@ import android.app.Activity
 import android.content.Intent
 import com.facebook.react.bridge.ReactContext
 
-internal sealed class MindboxSdkLifecyceEvent {
-    data class NewIntent(val reactContext: ReactContext, val intent: Intent) : MindboxSdkLifecyceEvent()
-    data class ActivityCreated(val reactContext: ReactContext, val activity: Activity) : MindboxSdkLifecyceEvent()
-    data class ActivityDestroyed(val activity: Activity) : MindboxSdkLifecyceEvent()
+internal sealed class MindboxSdkLifecycleEvent {
+    data class NewIntent(val reactContext: ReactContext, val intent: Intent) : MindboxSdkLifecycleEvent()
+    data class ActivityCreated(val reactContext: ReactContext, val activity: Activity) : MindboxSdkLifecycleEvent()
+    data class ActivityDestroyed(val activity: Activity) : MindboxSdkLifecycleEvent()
 }

android/src/main/java/com/mindboxsdk/MindboxSdkLifecycleListener.kt

@@ -46,7 +46,7 @@ internal class MindboxSdkLifecycleListener private constructor(
     private fun onReactContextAvailable(reactContext: ReactContext, activity: Activity) {
         Mindbox.writeLog("[RN] ReactContext ready", Level.INFO)
         addActivityEventListener(reactContext)
-        subscriber.onEvent(MindboxSdkLifecyceEvent.ActivityCreated(reactContext, activity))
+        subscriber.onEvent(MindboxSdkLifecycleEvent.ActivityCreated(reactContext, activity))
     }
 
     private fun registerReactContextListener(
@@ -93,7 +93,7 @@ internal class MindboxSdkLifecycleListener private constructor(
                     ?.takeIf { isMainActivity(it) }
                     ?.let {
                         subscriber.onEvent(
-                            MindboxSdkLifecyceEvent.NewIntent(
+                            MindboxSdkLifecycleEvent.NewIntent(
                                 reactContext,
                                 intent
                             )
@@ -111,7 +111,7 @@ internal class MindboxSdkLifecycleListener private constructor(
 
     override fun onActivityDestroyed(activity: Activity) {
         if (!isMainActivity(activity)) return
-        subscriber.onEvent(MindboxSdkLifecyceEvent.ActivityDestroyed(activity))
+        subscriber.onEvent(MindboxSdkLifecycleEvent.ActivityDestroyed(activity))
         getReactInstanceManager()
             ?.currentReactContext
             ?.removeActivityEventListener(activityEventListener)
@@ -135,7 +135,7 @@ internal class MindboxSdkLifecycleListener private constructor(
         wrapperListener: ReactInstanceManager.ReactInstanceEventListener
     ) {
         runCatching {
-            val reactApplication = application as? ReactApplication ?: return@runCatching
+            val reactApplication = application as ReactApplication
 
             val hostClass = Class.forName("com.facebook.react.ReactHost")
             val listenerClass = Class.forName("com.facebook.react.ReactInstanceEventListener")
@@ -157,7 +157,7 @@ internal class MindboxSdkLifecycleListener private constructor(
             addMethod.invoke(reactHost, proxy)
             Mindbox.writeLog("[RN] success added react context listener for reactHost", Level.INFO)
         }.onFailure {
-            Mindbox.writeLog("[RN] failed added react context listener for reactHost ", Level.INFO)
+            Mindbox.writeLog("[RN] failed added react context listener for reactHost ", Level.ERROR)
         }
     }
 }