Merge branch 'dev' into documentation_update

Author: priyakasimbeg

.github/workflows/regression_tests.yml

@@ -13,6 +13,9 @@ do
     esac
 done
 
+# Artifact repostiory
+ARTIFACT_REPO="europe-west-4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo"
+
 if [[ -z ${GIT_BRANCH+x} ]]
 then 
 GIT_BRANCH='main' # Set default argument
@@ -22,9 +25,9 @@ for FRAMEWORK in "jax" "pytorch" "both"
 do
     IMAGE_NAME="algoperf_${FRAMEWORK}_${GIT_BRANCH}"
     DOCKER_BUILD_COMMAND="docker build --no-cache -t $IMAGE_NAME . --build-arg framework=$FRAMEWORK --build-arg branch=$GIT_BRANCH"
-    DOCKER_TAG_COMMAND="docker tag $IMAGE_NAME us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/$IMAGE_NAME"
-    DOCKER_PUSH_COMMAND="docker push us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/$IMAGE_NAME"
-    DOCKER_PULL_COMMAND="docker pull us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/$IMAGE_NAME"
+    DOCKER_TAG_COMMAND="docker tag $IMAGE_NAME $ARTIFACT_REPO/$IMAGE_NAME"
+    DOCKER_PUSH_COMMAND="docker push $ARTIFACT_REPO/$IMAGE_NAME"
+    DOCKER_PULL_COMMAND="docker pull $ARTIFACT_REPO/$IMAGE_NAME"
 
     echo "On branch: ${GIT_BRANCH}"
     echo $DOCKER_BUILD_COMMAND

.github/workflows/regression_tests_variants.yml

@@ -40,8 +40,8 @@ write_files:
       ExecStartPre=mount --bind /var/lib/nvidia /var/lib/nvidia
       ExecStartPre=mount -o remountexec /var/lib/nvidia
       ExecStartPre=/usr/bin/docker-credential-gcr configure-docker --registries us-central1-docker.pkg.dev
-      ExecStartPre=/usr/bin/docker pull us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/base_image:latest
-      ExecStart=/usr/bin/docker run --rm --name=mlcommons --volume /var/lib/nvidia/lib64:/usr/local/nvidia/lib64 --volume /var/lib/nvidia/bin:/usr/local/nvidia/bin --device /dev/nvidia0:/dev/nvidia0  --device /dev/nvidia1:/dev/nvidia1 --device /dev/nvidia2:/dev/nvidia2 --device /dev/nvidia3:/dev/nvidia3 --device /dev/nvidia4:/dev/nvidia4 --device /dev/nvidia5:/dev/nvidia5 --device /dev/nvidia6:/dev/nvidia6 --device /dev/nvidia7:/dev/nvidia7 --device /dev/nvidia-uvm:/dev/nvidia-uvm --device /dev/nvidiactl:/dev/nvidiactl us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/base_image:latest -b true
+      ExecStartPre=/usr/bin/docker pull europe-west4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo/base_image:latest
+      ExecStart=/usr/bin/docker run --rm --name=mlcommons --volume /var/lib/nvidia/lib64:/usr/local/nvidia/lib64 --volume /var/lib/nvidia/bin:/usr/local/nvidia/bin --device /dev/nvidia0:/dev/nvidia0  --device /dev/nvidia1:/dev/nvidia1 --device /dev/nvidia2:/dev/nvidia2 --device /dev/nvidia3:/dev/nvidia3 --device /dev/nvidia4:/dev/nvidia4 --device /dev/nvidia5:/dev/nvidia5 --device /dev/nvidia6:/dev/nvidia6 --device /dev/nvidia7:/dev/nvidia7 --device /dev/nvidia-uvm:/dev/nvidia-uvm --device /dev/nvidiactl:/dev/nvidiactl europe-west4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo/base_image:latest -b true
       StandardOutput=journal+console
       StandardError=journal+console
 

docker/build_docker_images.sh

@@ -51,6 +51,8 @@ RSYNC_DATA="true"
 OVERWRITE="false"
 SAVE_CHECKPOINTS="true"
 TUNING_RULESET="external"
+ROOT_DATA_BUCKET="algoperf-data"
+LOGS_BUCKET="algoperf-runs"
 
 # Pass flag
 while [ "$1" != "" ]; do
@@ -136,6 +138,14 @@ while [ "$1" != "" ]; do
             shift
             ADDITIONAL_REQUIREMENTS_PATH=$1
             ;;
+        --data_bucket)
+            shift
+            ROOT_DATA_BUCKET=$1
+            ;;
+        --logs_bucket)
+            shift
+            LOGS_BUCKET=$1
+            ;;
         *) 
             usage 
             exit 1
@@ -179,11 +189,11 @@ VALID_WORKLOADS=("criteo1tb" "imagenet_resnet" "imagenet_resnet_silu" "imagenet_
 VALID_RULESETS=("self" "external")
 
 # Set data and experiment paths
-ROOT_DATA_BUCKET="gs://mlcommons-data"
 ROOT_DATA_DIR="${HOME_DIR}/data"
+ROOT_DATA_BUCKET="gs://${ROOT_DATA_BUCKET}"
 
-EXPERIMENT_BUCKET="gs://mlcommons-runs"
 EXPERIMENT_DIR="${HOME_DIR}/experiment_runs"
+EXPERIMENT_LOGS_BUCKET="gs://${LOGS_BUCKET}"
 
 if [[ -n ${DATASET+x} ]]; then 
     if [[ ! " ${VALID_DATASETS[@]} " =~ " $DATASET " ]]; then
@@ -283,7 +293,6 @@ if [[ ! -z ${SUBMISSION_PATH+x} ]]; then
         --workload=${WORKLOAD} \
         --submission_path=${SUBMISSION_PATH}  \
         --data_dir=${DATA_DIR} \
-        --num_tuning_trials=1  \
         --experiment_dir=${EXPERIMENT_DIR}  \
         --experiment_name=${EXPERIMENT_NAME} \
         --overwrite=${OVERWRITE} \
@@ -313,8 +322,8 @@ if [[ ! -z ${SUBMISSION_PATH+x} ]]; then
     RETURN_CODE=$?
 
     if [[ $INTERNAL_CONTRIBUTOR_MODE == "true" ]]; then 
-        /google-cloud-sdk/bin/gsutil -m cp -r ${EXPERIMENT_DIR}/${EXPERIMENT_NAME}/${WORKLOAD}_${FRAMEWORK} ${EXPERIMENT_BUCKET}/${EXPERIMENT_NAME}/
-        /google-cloud-sdk/bin/gsutil -m cp ${LOG_FILE} ${EXPERIMENT_BUCKET}/${EXPERIMENT_NAME}/${WORKLOAD}_${FRAMEWORK}/
+        /google-cloud-sdk/bin/gsutil -m cp -r ${EXPERIMENT_DIR}/${EXPERIMENT_NAME}/${WORKLOAD}_${FRAMEWORK} ${EXPERIMENT_LOGS_BUCKET}/${EXPERIMENT_NAME}/
+        /google-cloud-sdk/bin/gsutil -m cp ${LOG_FILE} ${EXPERIMENT_LOGS_BUCKET}/${EXPERIMENT_NAME}/${WORKLOAD}_${FRAMEWORK}/
     fi
 
 fi

docker/scripts/cloud-init.cfg

@@ -88,7 +88,7 @@ gcloud auth configure-docker $ARTIFACT_REGISTRY_URL
 To pull the latest prebuilt image:
 
 ```bash
-docker pull us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/<image_name>
+docker pull europe-west4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo/<image_name>
 ```
 
 The naming convention for `image_name` is `algoperf_<framework>_<branch>`.
@@ -102,7 +102,7 @@ Currently maintained images on the repository are:
 - `algoperf_both_dev`
 
 To reference the pulled image you will have to use the full `image_path`, e.g.
-`us-central1-docker.pkg.dev/training-algorithms-external/mlcommons-docker-repo/algoperf_jax_main`.
+`europe-west4-docker.pkg.dev/mlcommons-algoperf/algoperf-docker-repo/algoperf_jax_main`.
 
 ### Trigger Rebuild and Push of Maintained Images
 

docker/scripts/startup.sh

@@ -1,5 +1,6 @@
 """Submission file for an NAdamW optimizer with warmup+cosine LR in PyTorch."""
 
+import collections
 import math
 from typing import Any, Dict, Iterator, List, Optional, Tuple
 
@@ -24,6 +25,7 @@
     "weight_decay": 0.08121616522670176,
     "warmup_factor": 0.02
 }
+HPARAMS = collections.namedtuple('Hyperparameters', HPARAMS.keys())(**HPARAMS)
 
 
 # Modified from github.com/pytorch/pytorch/blob/v1.12.1/torch/optim/adamw.py.

docs/CONTRIBUTING.md

@@ -1,5 +1,6 @@
 """Submission file for an NAdamW optimizer with warmup+cosine LR in PyTorch."""
 
+import collections
 import math
 from typing import Any, Dict, Iterator, List, Optional, Tuple
 
@@ -24,6 +25,7 @@
     "weight_decay": 0.08121616522670176,
     "warmup_factor": 0.02
 }
+HPARAMS = collections.namedtuple('Hyperparameters', HPARAMS.keys())(**HPARAMS)
 
 
 # Modified from github.com/pytorch/pytorch/blob/v1.12.1/torch/optim/adamw.py.