Skip to content

Commit e722e9b

Browse files
author
Murilo Marinho
committed
[sas_robot_driver_myrobot] Removing line numbers from explanation snippets.
1 parent 451426c commit e722e9b

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

docs/source/sas/sas_robot_driver_add_new_robot.rst

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,6 @@ The files already exist, we just need to modify them as follows
9393
In :file:`CMakeLists.txt` we have a sequence of four blocks. These are all directly related to ROS2 and although in
9494
this tutorial I define a best practice, this is not particular to ``sas``.
9595

96-
97-
98-
9996
Making your own ``sas`` robot drivers
10097
-------------------------------------
10198

@@ -179,7 +176,6 @@ added or removed.
179176

180177
.. literalinclude:: ../../../sas_tutorial_workspace/src/sas_robot_driver_myrobot/include/sas_robot_driver_myrobot/sas_robot_driver_myrobot.hpp
181178
:language: cpp
182-
:linenos:
183179
:lines: 36-40
184180

185181
Second, we rely on the `PIMPL idiom <https://en.cppreference.com/w/cpp/language/pimpl>`_. This idiom is important to
@@ -189,7 +185,6 @@ is an important design aspect and should not be confused simply with aesthetics
189185

190186
.. literalinclude:: ../../../sas_tutorial_workspace/src/sas_robot_driver_myrobot/include/sas_robot_driver_myrobot/sas_robot_driver_myrobot.hpp
191187
:language: cpp
192-
:linenos:
193188
:lines: 47-49
194189

195190
When using the `PIMPL idiom <https://en.cppreference.com/w/cpp/language/pimpl>`_ it is important not to forget that the
@@ -198,7 +193,6 @@ this will depend heavily on the robot drivers.
198193

199194
.. literalinclude:: ../../../sas_tutorial_workspace/src/sas_robot_driver_myrobot/src/sas_robot_driver_myrobot.cpp
200195
:language: cpp
201-
:linenos:
202196
:lines: 36-51
203197

204198
Writing the ROS2 Node
@@ -261,19 +255,19 @@ The launch file will be like so.
261255
:linenos:
262256
:lines: 5-
263257

264-
The parameters should be no surprise defined as follows.
258+
The parameters should be no surprise defined as follows. The only one that was not defined by our struct
259+
``RobotDriverMyrobotConfiguration``, namely ``thread_sampling_time_sec``, is a parameter of ``sas::RobotDriverROSConfiguration``
260+
that defines the sampling time of the ROS2 loop.
265261

266262
.. literalinclude:: ../../../sas_tutorial_workspace/src/sas_robot_driver_myrobot/launch/real_robot_launch.py
267263
:language: python
268-
:linenos:
269264
:lines: 18-23
270265

271266
The most memorable aspect with respect to ``sas`` is that the ``name`` will define the topic prefixes. This is important
272267
to match other elements of ``sas``.
273268

274269
.. literalinclude:: ../../../sas_tutorial_workspace/src/sas_robot_driver_myrobot/launch/real_robot_launch.py
275270
:language: python
276-
:linenos:
277271
:lines: 17
278272

279273
Running the launch file

0 commit comments

Comments
 (0)