Skip to content

Commit fe2820d

Browse files
author
Murilo M. Marinho
committed
[docker] Fixing typos.
1 parent e65581d commit fe2820d

File tree

1 file changed

+9
-4
lines changed

1 file changed

+9
-4
lines changed

docs/source/docker/index.rst

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ Basic testing
4141
For the purposes of this illustration we will use the image
4242
`murilomarinho/sas`.
4343

44-
Docker run
45-
++++++++++
44+
Docker run interactively
45+
++++++++++++++++++++++++
4646

4747
Firstly it would be easier to tackle docker in simple commands before tackling complex
4848
scenarios.
@@ -82,8 +82,13 @@ Then, in the container and in the host we do as follows.
8282
export ROS_DOMAIN_ID=1
8383
ros2 topic echo /chatter
8484
85-
And notice that it will communicate without any issues. Changing the network settings of the
86-
docker image may cause this to stop working. For instance, a very popular setting is to use
85+
.. note::
86+
87+
In the container we have `ROS_DOMAIN_ID=1`. If this is modified in the container, this must
88+
be also modified in the host or they will not find and communicate with each other.
89+
90+
Notice that it will communicate without any issues. Changing the network settings of the
91+
docker container may cause this to stop working. For instance, a very popular setting is to use
8792
`--net=host`. This is not recommended unless strictly necessary because it will generate issues
8893
with ROS2 networking.
8994

0 commit comments

Comments
 (0)