[TASK] Improve error handling in logging

aertmann · aertmann · commit 8cd1bd7b4e89 · 2015-07-03T12:56:45.000+02:00
diff --git a/Classes/Aspects/ResourcePublisherAspect.php b/Classes/Aspects/ResourcePublisherAspect.php
@@ -127,7 +127,7 @@ public function optimizeFile($pathAndFilename) {
 		$cmd = escapeshellcmd($binaryPath) . ' ' . $arguments;
 		$output = [];
 		exec($cmd, $output, $result);
-		$this->systemLogger->log($cmd . ' (' . $result . ')', LOG_INFO, $output);
+		$this->systemLogger->log($cmd . ' (' . ((int)$result === 0 ? 'OK' : 'Error: ' . $result) . ')', LOG_INFO, $output);
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,7 @@ public function optimizeFile($pathAndFilename) {`
`127`	`127`	`$cmd = escapeshellcmd($binaryPath) . ' ' . $arguments;`
`128`	`128`	`$output = [];`
`129`	`129`	`exec($cmd, $output, $result);`
`130`		`- $this->systemLogger->log($cmd . ' (' . $result . ')', LOG_INFO, $output);`
	`130`	`+ $this->systemLogger->log($cmd . ' (' . ((int)$result === 0 ? 'OK' : 'Error: ' . $result) . ')', LOG_INFO, $output);`
`131`	`131`	`}`
`132`	`132`
`133`	`133`	`}`