Skip to content

Commit 52c5247

Browse files
committed
Print tool versions by calling script directly
The Litani job running `cbmc-starter-kit-print-tool-versions` forces both users running proofs locally as well as the CI environment to install the cbmc-starter-kit (either via brew or pip). Users and CI should not be forced to do that. Instead, the script can be invoked directly and the job will run. Testing: - Ran proofs locally on a personal fork (angelonakos/s2n-tls) containing 2 proofs and noticed the print-tool-versions Litani pipeline succeeding. - Tested in CI: https://github.com/angelonakos/s2n-tls/actions/runs/3750819777
1 parent 2157a88 commit 52c5247

File tree

3 files changed

+1
-2
lines changed

3 files changed

+1
-2
lines changed

setup.cfg

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,3 @@ console_scripts =
5454
cbmc-starter-kit-setup-proof = cbmc_starter_kit.setup_proof:main
5555
cbmc-starter-kit-setup-ci = cbmc_starter_kit.setup_ci:main
5656
cbmc-starter-kit-update = cbmc_starter_kit.update:main
57-
cbmc-starter-kit-print-tool-versions = cbmc_starter_kit.print_tool_versions:main
File renamed without changes.

src/cbmc_starter_kit/template-for-repository/proofs/run-cbmc-proofs.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ async def configure_proof_dirs( # pylint: disable=too-many-arguments
337337
def add_tool_version_job():
338338
cmd = [
339339
"litani", "add-job",
340-
"--command", "cbmc-starter-kit-print-tool-versions .",
340+
"--command", "./lib/print_tool_versions.py .",
341341
"--description", "printing out tool versions",
342342
"--phony-outputs", str(uuid.uuid4()),
343343
"--pipeline-name", "print_tool_versions",

0 commit comments

Comments
 (0)