Disposing IMcpClient and transport is unsafe

[asklar]

Describe the bug

await using var client = await McpClientFactory.CreateAsync(transport, clientOptions).ConfigureAwait(false);

This can throw OperationCanceledException as part of teardown; please consider swallowing cancellations that happen as part of DisposeAsync, or document how these should be handled with await using

[stephentoub]

Which transport? Can you share a standalone repro?

[asklar]

Hm looks like we were using the SseClientTransport from 0.3.0 but that's been renamed... I'll try with 0.4.0 HttpClientTransport; our usage is pretty straightforward:

public void Do()
{
    await using SseClientTransport transport = new (transportOptions);
    McpClientOptions clientOptions = new McpClientOptions
    {
        ClientInfo = new Implementation
        {
            Name = "Puppies and Rainbows",
            Version = "1.0.0"
        },
        InitializationTimeout = ProbeTimeout,
        ProtocolVersion = CurrentProtocolVersion,
        Capabilities = new ClientCapabilities()
    };

    await using IMcpClient client = await McpClientFactory.CreateAsync(transport, clientOptions).ConfigureAwait(false);

    // use the client
}           

With this setup, we see OperationCanceledException during DisposeAsync

[stephentoub]

I suspect this was fixed months ago. Please let us know if you can still repro after updating.