Skip to content

Potential overflow in day limit tracking #13

@joshuahannan

Description

@joshuahannan

When a transaction is executed, the amount of tokens in question are accounted for in the currentSpend mapping. Such increment is done with a simple + operator and is hence susceptible to an overflow, especially for non ether transactions. As a result of an overflow, token transfers above majorThreshold could be considered minor transactions and require an incorrect number of confirmations.
Consider using BasicMathLib’s plus function when incrementing such values.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions