Skip to content

Redundant error logs #16

@joshuahannan

Description

@joshuahannan

The wallet reverts when non-owners try to perform illegal operations on it. When owners try to perform illegal operations, or operations that cannot be performed for some reason, the wallet does not revert and instead returns false, emitting one or more error events describing the nature of the error in question.
WalletMainLib, in particular, emits two errors when an owner operation fails: LogErrorMsg and LogTransactionFailed. These two errors are always emitted as a pair, and doing so may be not only redundant, but could actually make it harder to find error information in the blockchain when the need arises.
Consider merging LogErrorMsg and LogTransactionFailed into a single event.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions