Merge pull request #23 from module-federation/drop_hot

ScriptedAlchemy · web-flow · commit f52f6ad95aee · 2022-05-05T12:08:01.000-07:00
remove hot experiment
diff --git a/README.md b/README.md
@@ -329,38 +329,12 @@ Options:
 // these are the defaults
 revalidate({
   // revalidate remotes by polling
-  poll: false,
+  poll: false, // defualt false
   // how ofter should it poll
   pollFrequeny: 3000, // defaults to 3000ms
 });
 ```
 
-1. Enable the hot experiment via the plugin
-
-```js
-withFederatedSidecar(
-  // normal MF config
-  {
-    name: "next1",
-    filename: "static/chunks/remoteEntry.js",
-    exposes: {},
-    remotes: {},
-    shared: {
-      react: {
-        requiredVersion: false,
-        singleton: true,
-      },
-    },
-  },
-  // sidecar specific options
-  {
-    experiments: {
-      hot: true,
-    },
-  }
-);
-```
-
 2. Inside `_document.js` (or `.tsx`) do the following:
 
 ```js
@@ -404,7 +378,7 @@ class MyDocument extends Document {
           <meta name="robots" content="noindex" />
           {Object.values(this.props.remoteChunks)}
         </ExtendedHead>
-        <DevHotScript /> {/* adds a timeout for process.env.NODE_ENV !== "development" */}
+        <DevHotScript /> {/* useful in development mode if you terminate processes on hot reload */}
         <body className="bg-background-grey">
           <Main />
           <NextScript />
@@ -561,7 +535,6 @@ withFederatedSidecar(
   {
     experiments: {
       flushChunks: true,
-      hot: true,
     },
   }
 );
diff --git a/lib/with-federated-sidecar.js b/lib/with-federated-sidecar.js
@@ -179,7 +179,6 @@ const withModuleFederation =
     {
       experiments = {
         flushChunks: false,
-        hot: false,
       },
       removePlugins = [
         "BuildManifestPlugin",
@@ -272,7 +271,7 @@ const withModuleFederation =
           chunkLoadingGlobal: undefined,
           devtoolNamespace: undefined,
           uniqueName: federationPluginOptions.name,
-          hotUpdateGlobal: "webpackHotUpdate_" + federationPluginOptions.name,
+          // hotUpdateGlobal: "webpackHotUpdate_" + federationPluginOptions.name,
           publicPath,
         },
         cache: false,
diff --git a/streaming/src/NodeModuleFederation/index.js b/streaming/src/NodeModuleFederation/index.js
@@ -147,10 +147,9 @@ class StreamingFederation {
     );
     const defs = {
       "process.env.REMOTES": runtime,
+      "process.env.REMOTE_CONFIG": hot,
     };
-    if (this.experiments.hot) {
-      defs["process.env.REMOTE_CONFIG"] = hot;
-    }
+
     new ((webpack && webpack.DefinePlugin) || require("webpack").DefinePlugin)(
       defs
     ).apply(compiler);
