Skip to content

Wrong key in regexParser? #1726

@tonysamperi

Description

@tonysamperi

Describe the bug
I think there's a mistake in your recent commit e434a47 in regexParser.js

const extractPartialIsoIntervalEndDate = simpleParse(
  "month",
  "day",
  "weekNumber",
  "weekDay", // This is wrong
  "ordinal"
);

Across the whole lib, it's weekday not weekDay. Not sure this causes problems, but if you were using typings, you would get an error there.

EDIT

Just found another one above

const extractISOWeekData = simpleParse("weekYear", "weekNumber", "weekDay");

I assume the object gets normalized afterwards. But for consistency, it should be weekday also here.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions