chore(lint): use devtools shared lint, fix errors VSCODE-723 (#1206)

Author: Anemy

.depcheckrc

@@ -1,8 +1,6 @@
 ignores:
- - "@mongodb-js/prettier-config-devtools"
  - "@types/jest"
  - "buffer"
- - "eslint-config-mongodb-js"
  - "mocha-junit-reporter"
  - "mocha-multi"
  - "mongodb-client-encryption"

.eslintrc.js

@@ -9,49 +9,22 @@ const ruleOverridesForJs = Object.keys(
 );
 
 const sharedRules = {
-  indent: 0,
-  'brace-style': 0,
-  'chai-friendly/no-unused-expressions': 0,
+  // TODO(VSCODE-724): Update our file naming and enable this rule.
+  // We have a lot of files that do not match the filename rules.
+  'filename-rules/match': 0,
   'mocha/no-exclusive-tests': 2,
-  'no-cond-assign': [2, 'except-parens'],
   'no-console': [1, { allow: ['warn', 'error', 'info'] }],
-  'no-empty-function': 0,
-  'no-shadow': 0,
-  'no-use-before-define': 0,
-  'object-curly-spacing': [2, 'always'],
-  'react/sort-comp': 0, // Does not seem work as expected with TypeScript.
-  'restrict-template-expressions': 0,
-  'space-before-function-paren': 0,
-  'valid-jsdoc': 0,
 };
 
 module.exports = {
   plugins: ['mocha', '@typescript-eslint'],
-  parser: '@typescript-eslint/parser', // Specifies the ESLint parser.
-  parserOptions: {
-    ecmaVersion: 2018,
-    sourceType: 'module',
-  },
-  extends: [
-    'eslint-config-mongodb-js/react',
-    'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended',
-    'plugin:@typescript-eslint/recommended-requiring-type-checking',
-  ],
+  extends: ['@mongodb-js/eslint-config-devtools'],
   overrides: [
     {
       files: ['*.ts', '*.tsx'],
       rules: {
         ...sharedRules,
-        semi: 0,
-        '@typescript-eslint/no-empty-function': 0,
-        '@typescript-eslint/no-use-before-define': 0,
         '@typescript-eslint/no-explicit-any': 0,
-        '@typescript-eslint/no-unused-vars': 2,
-        '@typescript-eslint/explicit-module-boundary-types': 0,
-        '@typescript-eslint/ban-types': 0,
-        '@typescript-eslint/semi': [2, 'always'],
-        '@typescript-eslint/restrict-template-expressions': 0,
         '@typescript-eslint/no-floating-promises': 2,
         // VV These rules we'd like to turn off one day so they error.
         '@typescript-eslint/no-unsafe-assignment': 0,
@@ -85,7 +58,6 @@ module.exports = {
       rules: {
         ...ruleOverridesForJs,
         ...sharedRules,
-        semi: [2, 'always'],
       },
     },
   ],

package.json

@@ -41,7 +41,7 @@
   "main": "./dist/extension.js",
   "scripts": {
     "clean": "rimraf -g ./out/* ./dist/*",
-    "lint": "eslint . && prettier --check .",
+    "lint": "eslint . --fix && prettier --check .",
     "update-grammar": "node ./scripts/update-grammar.ts",
     "precompile": "pnpm run clean",
     "compile": "npm-run-all compile:*",
@@ -50,7 +50,7 @@
     "compile:extension": "tsc -p ./",
     "compile:extension-bundles": "webpack --mode development",
     "watch": "pnpm run compile && npm-run-all -p watch:*",
-    "watch:extension": "pnpm run compile:extension -- -watch",
+    "watch:extension": "tsc -p ./ --watch",
     "watch:extension-bundles": "webpack --mode development --watch",
     "pretest": "pnpm run compile",
     "test": "pnpm run test-webview && pnpm run test-extension",
@@ -65,7 +65,7 @@
     "local-install": "pnpm run package && code --install-extension ./mongodb-vscode-*.vsix",
     "check-vsix-size": "node ./scripts/check-vsix-size.ts",
     "release-draft": "node ./scripts/release-draft.js",
-    "reformat": "prettier --write .",
+    "reformat": "eslint . --fix && prettier --write .",
     "snyk-test": "node scripts/snyk-test.js",
     "generate-icon-font": "node ./scripts/generate-icon-font.ts",
     "generate-vulnerability-report": "mongodb-sbom-tools generate-vulnerability-report --snyk-reports=.sbom/snyk-test-result.json --dependencies=.sbom/dependencies.json --fail-on=high",
@@ -1446,6 +1446,7 @@
     "@babel/preset-typescript": "^7.25.7",
     "@babel/types": "^7.25.8",
     "@modelcontextprotocol/sdk": "^1.24.0",
+    "@mongodb-js/eslint-config-devtools": "^0.9.12",
     "@mongodb-js/oidc-mock-provider": "^0.11.5",
     "@mongodb-js/oidc-plugin": "^2.0.5",
     "@mongodb-js/prettier-config-devtools": "^1.0.2",
@@ -1481,7 +1482,6 @@
     "depcheck": "^1.4.7",
     "duplicate-package-checker-webpack-plugin": "^3.0.0",
     "eslint": "^8.57.1",
-    "eslint-config-mongodb-js": "^5.0.3",
     "eslint-plugin-mocha": "^10.5.0",
     "fork-ts-checker-webpack-plugin": "^9.0.2",
     "glob": "^7.2.3",