Linting

Author: NoahStapp

django_mongodb_backend/compiler.py

@@ -359,7 +359,6 @@ def execute_sql(
         except EmptyResultSet:
             return iter([]) if result_type == MULTI else None
 
-        # print(f"Query: {query}")
         cursor = query.get_cursor()
         if result_type == SINGLE:
             try:
@@ -786,7 +785,6 @@ def explain_query(self):
         for option in self.connection.ops.explain_options:
             if value := options.get(option):
                 kwargs[option] = value
-        # print(f"PIPELINE: {pipeline}")
         explain = self.connection.database.command(
             "explain",
             {"aggregate": self.collection_name, "pipeline": pipeline, "cursor": {}},

django_mongodb_backend/gis/features.py

@@ -43,8 +43,6 @@ def django_test_skips(self):
                     "gis_tests.distapp.tests.DistanceTest.test_distance_lookups",
                     "gis_tests.distapp.tests.DistanceTest.test_distance_lookups_with_expression_rhs",
                     "gis_tests.distapp.tests.DistanceTest.test_distance_annotation_group_by",
-                    # "gis_tests.distapp.tests.DistanceFunctionsTests.test_distance_simple",
-                    # "gis_tests.distapp.tests.DistanceFunctionsTests.test_distance_order_by",
                 },
                 "ImproperlyConfigured isn't raised when using RasterField": {
                     # Normally RasterField.db_type() raises an error, but MongoDB

django_mongodb_backend/gis/lookups.py

@@ -9,8 +9,8 @@ def _gis_lookup(self, compiler, connection, as_expr=False):
     rhs_mql = process_rhs(self, compiler, connection, as_expr=as_expr)
     try:
         rhs_op = self.get_rhs_op(connection, rhs_mql)
-    except KeyError:
-        raise NotSupportedError(f"MongoDB does not support the '{self.lookup_name}' lookup.")
+    except KeyError as e:
+        raise NotSupportedError(f"MongoDB does not support the '{self.lookup_name}' lookup.") from e
     return rhs_op.as_mql(lhs_mql, rhs_mql, self.rhs_params)
 
 

django_mongodb_backend/gis/operations.py

@@ -9,8 +9,7 @@
 from .utils import SpatialOperator
 
 
-def _gis_within_operator(field, value, op=None, params=None):
-    # print(f"Within value: {value}")
+def _gis_within_operator(field, value, op=None, params=None):  # noqa: ARG001
     return {
         field: {
             "$geoWithin": {
@@ -23,7 +22,7 @@ def _gis_within_operator(field, value, op=None, params=None):
     }
 
 
-def _gis_intersects_operator(field, value, op=None, params=None):
+def _gis_intersects_operator(field, value, op=None, params=None):  # noqa: ARG001
     return {
         field: {
             "$geoIntersects": {
@@ -36,7 +35,7 @@ def _gis_intersects_operator(field, value, op=None, params=None):
     }
 
 
-def _gis_disjoint_operator(field, value, op=None, params=None):
+def _gis_disjoint_operator(field, value, op=None, params=None):  # noqa: ARG001
     return {
         field: {
             "$not": {
@@ -51,7 +50,7 @@ def _gis_disjoint_operator(field, value, op=None, params=None):
     }
 
 
-def _gis_contains_operator(field, value, op=None, params=None):
+def _gis_contains_operator(field, value, op=None, params=None):  # noqa: ARG001
     value_type = value["type"]
     if value_type != "Point":
         raise NotSupportedError("MongoDB does not support contains on non-Point query geometries.")
@@ -68,11 +67,7 @@ def _gis_contains_operator(field, value, op=None, params=None):
 
 
 def _gis_distance_operator(field, value, op=None, params=None):
-    # print(f"Distance: {params}")
-    if hasattr(params[0], "m"):
-        distance = params[0].m
-    else:
-        distance = params[0]
+    distance = params[0].m if hasattr(params[0], "m") else params[0]
     if op == "distance_gt" or op == "distance_gte":
         cmd = {
             field: {
@@ -97,7 +92,6 @@ def _gis_distance_operator(field, value, op=None, params=None):
                 }
             }
         }
-    # print(f"Command: {cmd}")
     return cmd