CLOUDP-285948: add support for flex clusters to 'atlas backup snaphots get' (#3482)

Author: andreaangiolillo

internal/cli/backup/snapshots/describe.go

@@ -25,12 +25,17 @@ import (
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/store"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/usage"
 	"github.com/spf13/cobra"
+	atlasv2 "go.mongodb.org/atlas-sdk/v20241113002/admin"
 )
 
 const describeTemplate = `ID	SNAPSHOT TYPE	TYPE	DESCRIPTION	EXPIRES AT
 {{.Id}}	{{.SnapshotType}}	{{.Type}}	{{.Description}}	{{.ExpiresAt}}
 `
 
+const describeTemplateFlex = `ID	STATUS	MONGODB VERSION	START TIME	FINISH TIME	EXPIRATION
+{{.Id}}	{{.Status}}	{{.MongoDBVersion}}	{{.StartTime}}	{{.FinishTime}}	{{.Expiration}}
+`
+
 type DescribeOpts struct {
 	cli.ProjectOpts
 	cli.OutputOpts
@@ -48,22 +53,39 @@ func (opts *DescribeOpts) initStore(ctx context.Context) func() error {
 }
 
 func (opts *DescribeOpts) Run() error {
-	r, err := opts.store.Snapshot(opts.ConfigProjectID(), opts.clusterName, opts.snapshot)
+	r, err := opts.store.FlexClusterSnapshot(opts.ConfigProjectID(), opts.clusterName, opts.snapshot)
+	if err == nil {
+		opts.Template = describeTemplateFlex
+		return opts.Print(r)
+	}
+
+	apiError, ok := atlasv2.AsError(err)
+	if !ok {
+		return err
+	}
+
+	if apiError.ErrorCode != cannotUseNotFlexWithFlexApisErrorCode {
+		return err
+	}
+
+	snapshots, err := opts.store.Snapshot(opts.ConfigProjectID(), opts.clusterName, opts.snapshot)
 	if err != nil {
 		return err
 	}
 
-	return opts.Print(r)
+	return opts.Print(snapshots)
 }
 
+// DescribeBuilder builds a cobra.Command that can run as:
 // atlas backup snapshots describe snapshotId  --clusterName clusterName --projectId projectId.
 func DescribeBuilder() *cobra.Command {
 	opts := new(DescribeOpts)
 	cmd := &cobra.Command{
-		Use:   "describe <snapshotId>",
-		Short: "Return the details for the specified snapshot for your project.",
-		Long:  fmt.Sprintf(usage.RequiredRole, "Project Read Only"),
-		Args:  require.ExactArgs(1),
+		Use:     "describe <snapshotId>",
+		Aliases: []string{"get"},
+		Short:   "Return the details for the specified snapshot for your project.",
+		Long:    fmt.Sprintf(usage.RequiredRole, "Project Read Only"),
+		Args:    require.ExactArgs(1),
 		Example: `  # Return the details for the backup snapshot with the ID 5f4007f327a3bd7b6f4103c5 for the cluster named myDemo:
   atlas backups snapshots describe 5f4007f327a3bd7b6f4103c5 --clusterName myDemo`,
 		Annotations: map[string]string{

internal/cli/backup/snapshots/describe_test.go

@@ -22,6 +22,7 @@ import (
 	"github.com/golang/mock/gomock"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/mocks"
 	"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/test"
+	"github.com/stretchr/testify/require"
 	atlasv2 "go.mongodb.org/atlas-sdk/v20241113002/admin"
 )
 
@@ -35,14 +36,40 @@ func TestDescribe_Run(t *testing.T) {
 		store: mockStore,
 	}
 
+	expectedError := &atlasv2.GenericOpenAPIError{}
+	expectedError.SetModel(atlasv2.ApiError{ErrorCode: cannotUseNotFlexWithFlexApisErrorCode})
+
+	mockStore.
+		EXPECT().
+		FlexClusterSnapshot(describeOpts.ProjectID, describeOpts.clusterName, describeOpts.snapshot).
+		Return(nil, expectedError).
+		Times(1)
+
 	mockStore.
 		EXPECT().
 		Snapshot(describeOpts.ProjectID, describeOpts.clusterName, describeOpts.snapshot).
 		Return(&expected, nil).
 		Times(1)
 
-	if err := describeOpts.Run(); err != nil {
-		t.Fatalf("Run() unexpected error: %v", err)
-	}
+	require.NoError(t, describeOpts.Run())
 	test.VerifyOutputTemplate(t, describeTemplate, expected)
 }
+
+func TestDescribe_Run_FlexCluster(t *testing.T) {
+	ctrl := gomock.NewController(t)
+	mockStore := mocks.NewMockSnapshotsDescriber(ctrl)
+	expected := &atlasv2.FlexBackupSnapshot20241113{}
+
+	describeOpts := &DescribeOpts{
+		store: mockStore,
+	}
+
+	mockStore.
+		EXPECT().
+		FlexClusterSnapshot(describeOpts.ProjectID, describeOpts.clusterName, describeOpts.snapshot).
+		Return(expected, nil).
+		Times(1)
+
+	require.NoError(t, describeOpts.Run())
+	test.VerifyOutputTemplate(t, describeTemplateFlex, expected)
+}

internal/cli/backup/snapshots/snapshots.go

@@ -19,6 +19,10 @@ import (
 	"github.com/spf13/cobra"
 )
 
+const (
+	cannotUseNotFlexWithFlexApisErrorCode = "CANNOT_USE_NON_FLEX_CLUSTER_IN_FLEX_API"
+)
+
 func Builder() *cobra.Command {
 	const use = "snapshots"
 	cmd := &cobra.Command{