upgrade go version to 1.24.1 (#15)

Author: husniMDB

.github/workflows/code-health.yml

@@ -17,9 +17,9 @@ jobs:
           go-version-file: 'go.mod'
           cache: false # see https://github.com/golangci/golangci-lint-action/issues/807
       - name: golangci-lint
-        uses: golangci/[email protected].0
+        uses: golangci/[email protected].2
         with:
-          version: v1.56.1
+          version: v1.64.6
   unit-tests:
     env:
       COVERAGE: coverage.out

.golangci.yml

@@ -6,10 +6,6 @@ linters-settings:
     min-occurrences: 2
   gocyclo:
     min-complexity: 15
-  govet:
-    check-shadowing: true
-  maligned:
-    suggest-new: true
   misspell:
     locale: US
     ignore-words:
@@ -23,12 +19,15 @@ linters-settings:
       - name: blank-imports
       - name: context-as-argument
       - name: context-keys-type
+      - name: defer
       - name: dot-imports
       - name: error-return
       - name: error-strings
       - name: error-naming
+      - name: early-return
       - name: errorf
       - name: exported
+      - name: import-shadowing
       - name: indent-error-flow
       - name: if-return
       - name: increment-decrement
@@ -52,23 +51,22 @@ linters-settings:
       - name: constant-logical-expr
       - name: confusing-naming
       - name: unnecessary-stmt
-      - name: imports-blacklist
+      - name: use-any
+      - name: imports-blocklist
         arguments:
           - "github.com/pkg/errors"
   gci:
     sections:
       - standard
       - default
-    section-separators:
-      - newLine
 linters:
   disable-all: true
   enable:
     - dogsled # Checks assignments with too many blank identifiers (e.g. x, _, _, _, := f()) [fast: true, auto-fix: false]
     - errcheck # Errcheck is a program for checking for unchecked errors in go programs. These unchecked errors can be critical bugs in some cases [fast: false, auto-fix: false]
     - errorlint # Errorlint is a linter that can be used to find code that will cause problems with the error wrapping scheme introduced in Go 1.13.
     - exhaustive # check exhaustiveness of enum switch statements [fast: false, auto-fix: false]
-    - exportloopref # checks for pointers to enclosing loop variables [fast: false, auto-fix: false]
+    - copyloopvar # copyloopvar is a linter detects places where loop variables are copied. Replaces exportloopref since Go1.22
     - gci # Gci controls golang package import order and makes it always deterministic. [fast: true, auto-fix: false]
     - gochecknoinits # Checks that no init functions are present in Go code [fast: true, auto-fix: false]
     - goconst # Finds repeated strings that could be replaced by a constant [fast: true, auto-fix: false]
@@ -77,7 +75,7 @@ linters:
     - godot # Check if comments end in a period [fast: true, auto-fix: true]
     - gofmt # Gofmt checks whether code was gofmt-ed. By default this tool runs with -s option to check for code simplification [fast: true, auto-fix: true]
     - goimports # In addition to fixing imports, goimports also formats your code in the same style as gofmt. [fast: true, auto-fix: true]
-    - gomnd # An analyzer to detect magic numbers. [fast: true, auto-fix: false]
+    - mnd # An analyzer to detect magic numbers. [fast: true, auto-fix: false]
     - goprintffuncname # Checks that printf-like functions are named with `f` at the end [fast: true, auto-fix: false]
     - gosec # (gas) Inspects source code for security problems [fast: false, auto-fix: false]
     - gosimple # (megacheck) Linter for Go source code that specializes in simplifying code [fast: false, auto-fix: false]
@@ -94,7 +92,7 @@ linters:
     - rowserrcheck # checks whether Err of rows is checked successfully [fast: false, auto-fix: false]
     - staticcheck # (megacheck) It's a set of rules from staticcheck. It's not the same thing as the staticcheck binary. The author of staticcheck doesn't support or approve the use of staticcheck as a library inside golangci-lint. [fast: false, auto-fix: false]
     - stylecheck # Stylecheck is a replacement for golint [fast: false, auto-fix: false]
-    - tenv # tenv is analyzer that detects using os.Setenv instead of t.Setenv since Go1.17 [fast: false, auto-fix: false]
+    - usetesting # Reports uses of functions with replacement inside the testing package. [auto-fix]
     - testifylint # Checks usage of github.com/stretchr/testify. [fast: false, auto-fix: false]
     - thelper # thelper detects golang test helpers without t.Helper() call and checks the consistency of test helpers [fast: false, auto-fix: false]
     - typecheck # Like the front-end of a Go compiler, parses and type-checks Go code [fast: false, auto-fix: false]
@@ -174,8 +172,6 @@ run:
     - e2e
     - unit
     - integration
-  skip-dirs:
-    - internal/mocks
   modules-download-mode: readonly
 
 issues:
@@ -186,9 +182,4 @@ issues:
         - gocyclo
     - path: internal/test/fixture # Don't check for magic numbers on fixtures.
       linters:
-        - gomnd
-    - path: internal/kubernetes/*
-      linters:
-        - nolintlint
-        - gci
-        - gocyclo
+        - mnd

go.mod

@@ -1,6 +1,6 @@
 module github.com/mongodb/mongodb-cli/mongocli/v2
 
-go 1.22.5
+go 1.24.1
 
 require (
 	github.com/AlecAivazis/survey/v2 v2.3.7

internal/cli/auth/login_test.go

@@ -18,7 +18,6 @@ package auth
 
 import (
 	"bytes"
-	"context"
 	"errors"
 	"fmt"
 	"testing"
@@ -76,7 +75,7 @@ func Test_loginOpts_Run(t *testing.T) {
 		ExpiresIn:       300,
 		Interval:        10,
 	}
-	ctx := context.TODO()
+	ctx := t.Context()
 	mockFlow.
 		EXPECT().
 		RequestCode(ctx).
@@ -129,11 +128,11 @@ Successfully logged in as [email protected].
 
 type confirmMock struct{}
 
-func (confirmMock) Prompt(_ *survey.PromptConfig) (interface{}, error) {
+func (confirmMock) Prompt(_ *survey.PromptConfig) (any, error) {
 	return true, nil
 }
 
-func (confirmMock) Cleanup(_ *survey.PromptConfig, _ interface{}) error {
+func (confirmMock) Cleanup(_ *survey.PromptConfig, _ any) error {
 	return nil
 }
 

internal/cli/auth/logout_test.go

@@ -18,7 +18,6 @@ package auth
 
 import (
 	"bytes"
-	"context"
 	"testing"
 
 	"github.com/golang/mock/gomock"
@@ -53,7 +52,7 @@ func Test_logoutOpts_Run(t *testing.T) {
 			Confirm: true,
 		},
 	}
-	ctx := context.TODO()
+	ctx := t.Context()
 	mockFlow.
 		EXPECT().
 		RevokeToken(ctx, gomock.Any(), gomock.Any()).
@@ -83,7 +82,7 @@ func Test_logoutOpts_Run_Keep(t *testing.T) {
 		},
 		keepConfig: true,
 	}
-	ctx := context.TODO()
+	ctx := t.Context()
 	mockFlow.
 		EXPECT().
 		RevokeToken(ctx, gomock.Any(), gomock.Any()).

internal/cli/config/set.go

@@ -43,7 +43,7 @@ func (opts *SetOpts) Run() error {
 			return err
 		}
 	}
-	var value interface{}
+	var value any
 	value = opts.val
 	if search.StringInSlice(config.BooleanProperties(), opts.prop) {
 		value = config.IsTrue(opts.val)

internal/cli/delete_opts.go

@@ -46,7 +46,7 @@ func NewDeleteOpts(successMsg, failMsg string) *DeleteOpts {
 
 // Delete deletes a resource not associated to a project, it expects a callback
 // that should perform the deletion from the store.
-func (opts *DeleteOpts) Delete(d interface{}, a ...string) error {
+func (opts *DeleteOpts) Delete(d any, a ...string) error {
 	if !opts.Confirm {
 		fmt.Println(opts.FailMessage())
 		return nil

internal/cli/iam/projects/list.go

@@ -48,7 +48,7 @@ func (opts *ListOpts) initStore(ctx context.Context) func() error {
 }
 
 func (opts *ListOpts) Run() error {
-	var r interface{}
+	var r any
 	var err error
 	listOptions := opts.NewListOptions()
 	if opts.ConfigOrgID() != "" && config.Service() == config.OpsManagerService {

internal/cli/iam/teams/describe.go

@@ -49,7 +49,7 @@ func (opts *DescribeOpts) initStore(ctx context.Context) func() error {
 }
 
 func (opts *DescribeOpts) Run() error {
-	var r interface{}
+	var r any
 	var err error
 
 	if opts.name != "" {

internal/cli/iam/users/describe.go

@@ -48,7 +48,7 @@ func (opts *DescribeOpts) initStore(ctx context.Context) func() error {
 }
 
 func (opts *DescribeOpts) Run() error {
-	var r interface{}
+	var r any
 	var err error
 
 	if opts.username != "" {