Cleanup TODOs

Author: Julien-Ben

scripts/release/atomic_pipeline.py

@@ -594,14 +594,13 @@ def build_multi_arch_agent_in_sonar(
     build_image_generic(
         image_name="mongodb-agent-ubi",
         dockerfile_path="docker/mongodb-agent-non-matrix/Dockerfile",
-        build_configuration=build_config_copy,
+        build_configuration=build_config_copy, #TODO: why ?
         is_multi_arch=True,
         multi_arch_args_list=joined_args,
     )
 
 
-# TODO: why versions are wrong -> 13.35.0.9498-1_13.35.0.9498-1_6874c19d2aab5d0007820c51 ; duplicate
-# TODO: figure out why I hit toomanyrequests: Rate exceeded with the new pipeline
+# TODO: Observed rate limiting (429) sometimes for agent builds in patches
 def build_agent_default_case(build_configuration: BuildConfiguration):
     """
     Build the agent only for the latest operator for patches and operator releases.
@@ -646,7 +645,6 @@ def build_agent_default_case(build_configuration: BuildConfiguration):
     queue_exception_handling(tasks_queue)
 
 
-# TODO: for now, release agents ECR release versions with image:version_version (duplicated)
 def build_agent_on_agent_bump(build_configuration: BuildConfiguration):
     """
     Build the agent matrix (operator version x agent version), triggered by PCT.

scripts/release/build_context.py

@@ -23,15 +23,15 @@ def infer_scenario_from_environment(cls) -> "BuildScenario":
         patch_id = os.getenv("version_id")
 
         if git_tag:
-            scenario = BuildScenario.RELEASE
+            scenario = BuildScenario.RELEASE # TODO: git tag won't trigger the pipeline, only the promotion process
             logger.info(f"Build scenario: {scenario} (git_tag: {git_tag})")
         elif is_patch:
             scenario = BuildScenario.PATCH
             logger.info(f"Build scenario: {scenario} (patch_id: {patch_id})")
         elif is_evg:
             scenario = (
                 BuildScenario.MASTER
-            )  # TODO: ultimately we won't have RELEASE variant and master will push to staging
+            )  # TODO: MASTER -> Staging
             logger.info(f"Build scenario: {scenario} (patch_id: {patch_id})")
         else:
             scenario = BuildScenario.DEVELOPMENT

scripts/release/build_images.py

@@ -15,7 +15,6 @@
 from scripts.evergreen.release.images_signing import sign_image, verify_signature
 
 
-# TODO: self review the PR
 def ecr_login_boto3(region: str, account_id: str):
     """
     Fetches an auth token from ECR via boto3 and logs
@@ -43,7 +42,7 @@ def ecr_login_boto3(region: str, account_id: str):
     logger.debug(f"ECR login succeeded: {status}")
 
 
-# TODO: don't do it every time ? Check for existence without relying on Exception
+# TODO: use builders = docker.buildx.list() instead of an exception
 def ensure_buildx_builder(builder_name: str = "multiarch") -> str:
     """
     Ensures a Docker Buildx builder exists for multi-platform builds.
@@ -144,18 +143,6 @@ def process_image(
     # Login to ECR using boto3
     ecr_login_boto3(region="us-east-1", account_id="268558157000")  # TODO: use environment variables
 
-    # Helper to automatically create registry with correct name
-    should_create_repo = False
-    if should_create_repo:
-        repo_to_create = "julienben/staging-temp/" + image_name
-        logger.debug(f"repo_to_create: {repo_to_create}")
-        create_ecr_repository(repo_to_create)
-        logger.info(f"Created repository {repo_to_create}")
-
-    # Set default platforms if none provided TODO: remove from here and do it at higher level later
-    if platforms is None:
-        platforms = ["linux/amd64"]
-
     docker_registry = f"{base_registry}/{image_name}"
     image_full_uri = f"{docker_registry}:{image_tag}"