Skip to content

Commit 122eaa5

Browse files
Fix "draft release note found" while promoting kubectl plugin (#601)
1 parent 6cf07fa commit 122eaa5

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

scripts/release/kubectl_mongodb/promote_kubectl_plugin.py

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -285,18 +285,27 @@ def upload_assets_to_github_release(asset_paths: list[str], release_version: str
285285
sys.exit(1)
286286

287287
try:
288-
release = repo.get_release(release_version)
288+
gh_release = None
289+
# list all the releases (including draft ones), and get the one corresponding to the passed release_version
290+
for r in repo.get_releases():
291+
if r.tag_name == release_version:
292+
gh_release = r
293+
break
294+
295+
if gh_release is None:
296+
logger.error(
297+
f"Could not find release (published or draft) with tag '{release_version}'. Please ensure the release exists."
298+
)
299+
sys.exit(2)
289300
except GithubException as e:
290-
logger.debug(
291-
f"ERROR: Could not find release with tag '{release_version}'. Please ensure release exists already. Error: {e}"
292-
)
301+
logger.debug(f"Failed to retrieve releases from the repository {GITHUB_REPO}. Error: {e}")
293302
sys.exit(2)
294303

295304
for asset_path in asset_paths:
296305
asset_name = os.path.basename(asset_path)
297306
logger.info(f"Uploading artifact '{asset_name}' to github release as asset")
298307
try:
299-
release.upload_asset(path=asset_path, name=asset_name, content_type="application/gzip")
308+
gh_release.upload_asset(path=asset_path, name=asset_name, content_type="application/gzip")
300309
except GithubException as e:
301310
logger.debug(f"ERROR: Failed to upload asset {asset_name}. Error: {e}")
302311
sys.exit(2)

0 commit comments

Comments
 (0)