Commit 12f405a
authored
Clarify hostname and service name in external mongod search snippets (#483)
# Summary
This pull request updates the configuration and code snippets for
setting up an external MongoDB Search service to improve clarity and
consistency in variable naming. The main change is the introduction of
the `MDB_SEARCH_SERVICE_NAME` variable, replacing the previous use of
`MDB_SEARCH_HOSTNAME` for Kubernetes service references, while
`MDB_SEARCH_HOSTNAME` is now used specifically for the DNS hostname.
**Configuration variable updates:**
* Introduced `MDB_SEARCH_SERVICE_NAME` to represent the Kubernetes
service name and updated all related references in `env_variables.sh`
and `README.md`. The `MDB_SEARCH_HOSTNAME` variable is now used to
specify the DNS hostname (e.g., `mdbs-search.example.com`).
[[1]](diffhunk://#diff-e45215de7c861006344586b40839be9eff775ee82754ace9f0d83f208fcb127fL11-R12)
[[2]](diffhunk://#diff-78a9bbf913195ad01e7814be0a2937858af6c019f895fa45726b5730974bc78cL53-R54)
**Kubernetes service creation and referencing:**
* Updated service creation in
`04_0322_create_search_loadbalancer_service.sh` to use
`MDB_SEARCH_SERVICE_NAME` for the service name instead of
`MDB_SEARCH_HOSTNAME`.
* Changed all `kubectl` commands and log messages in scripts to
reference `MDB_SEARCH_SERVICE_NAME` instead of `MDB_SEARCH_HOSTNAME`,
ensuring consistency throughout the deployment process.
[[1]](diffhunk://#diff-3b631e2e08f0d1e1b57c8118a489bd479473d66343885e68b50f8614589a2954L16-R20)
[[2]](diffhunk://#diff-7f7d23e97cadad8c2d81c63dab8f285f921bfbd83f39940febd47989a60986e1L1-R7)
## Proof of Work
Snippet tests pass1 parent e6e167f commit 12f405a
File tree
4 files changed
+10
-8
lines changed- docs/search/04-search-external-mongod
- code_snippets
4 files changed
+10
-8
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
| 54 | + | |
54 | 55 | | |
55 | 56 | | |
56 | 57 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
16 | | - | |
| 16 | + | |
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
| 20 | + | |
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| |||
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
| 12 | + | |
12 | 13 | | |
13 | 14 | | |
14 | 15 | | |
| |||
0 commit comments