Skip to content

Warning about componentWillReceiveProps in React's Strict Mode #624

New issue
New issue
Open
#735
Open
Warning about componentWillReceiveProps in React's Strict Mode#624
#735
Labels
help wanted
@ulrichb

Description

@ulrichb
ulrichb
opened on Mar 16, 2019

React's Strict Mode warns about "Unsafe lifecycle methods were found within a strict-mode tree".

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead.

react-autosuggest/src/Autosuggest.js

Lines 124 to 143 in d626cef

componentWillReceiveProps(nextProps) {
if (shallowEqualArrays(nextProps.suggestions, this.props.suggestions)) {
if (
nextProps.highlightFirstSuggestion &&
nextProps.suggestions.length > 0 &&
this.justPressedUpDown === false &&
this.justMouseEntered === false
) {
this.highlightFirstSuggestion();
}
} else {
if (this.willRenderSuggestions(nextProps)) {
if (this.state.isCollapsed && !this.justSelectedSuggestion) {
this.revealSuggestions();
}
} else {
this.resetHighlightedSuggestion();
}
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wanted

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions