Discussion: PyO3 Binding Design

[besaleli]

I think we do something like:

encoderfile = Encoderfile(
  name = "my-encoderfile",
  ...
)

encoderfile.build()

To introspect an encoderfile:

encoderfile = Encoderfile.from_file("path/to/my/encoderfile")

[javiermtorres]

LGTM. Do we want any other access to the onnx model somehow? I'd say it beats the purpose of encoderfile, but just in case.

[besaleli]

@javiermtorres I don't see a reason to. They can just load the onnx model themselves yes? We'd have to add deps to the library and i'd like to keep it dep-free ideally

[javiermtorres]

Totally agreed.