replace freezegun with time-machine #24020
Merged
+393
−285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eviljeff
force-pushed
the
15892-replace-freezegun-with-timemachine
branch
4 times, most recently
from
cf80bc4 to
24beb46
Compare
eviljeff
force-pushed
the
15892-replace-freezegun-with-timemachine
branch
from
24beb46 to
6d597d3
Compare
willdurand
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15892
Description
Replaces freezegun with time-machine.
Context
time machine defaults to
tick=True, which is probably perfectly fine - and preferable - in most cases, but for ease of migration I addedtick=Falseeverywhere. (Though the one test class I thought it'd be fine in -TestReviewReports- was broken without it).Testing
N/A - it only affects tests
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.