[Task]: limit scope of soft-block deleted versions backfill task

[eviljeff]

Description

The process_versions task block_old_deleted_versions currently soft-blocks all deleted versions of add-ons (that are not already subject to some kind of block). The request is to limit this to non-promoted add-ons.

Assumptions that need to be validated before proceeding:

• I'm assuming this is version specific, like the command, i.e. a version that is approved for any promotion is skipped, rather than a version of an add-on that is promoted at the current time.
  • I.e. an old deleted version of an add-on would be soft-blocked if that version wasn't approved for a promotion, even if the current version of that add-on is approved for a promotion now.
  • Conversely, an old deleted version of an add-on wouldn't be soft-blocked if it was approved for a promotion, even if the add-on is not currently in any promotion group
• This limitation is for any promotional group.

Note:

• block_old_deleted_versions was already executed once, but failed due to a bug. This lead to a random(-ish) selection of deleted versions being correctly soft-blocked, while others weren't. Some of the soft-blocked deleted versions were promoted. Changing the blocked state of those already affected versions is not in scope - they will remain soft-blocked.
• For new deletions of versions, all are soft-blocked, regardless of the promotional state. There are warnings in devhub and api documentation for developers about this. This won't change.

Acceptance Criteria

• process_versions --task=block_old_deleted_versions doesn't soft-block deleted promoted versions

┆Issue is synchronized with this Jira Task

[wagnerand-moz]

I believe this is still under consideration. Several people have raised questions or concerns about limiting to non-promoted.

[eviljeff]

I believe this is still under consideration. Several people have raised questions or concerns about limiting to non-promoted.

This issue can be a record of what is eventually decided, and by whom.