Lint

Author: mashalifshin

jobs/ads-incrementality-dap-collector/.flake8

@@ -1,2 +1,2 @@
 [flake8]
-max-line-length = 88
+max-line-length = 120

jobs/ads-incrementality-dap-collector/ads_incrementality_dap_collector/constants.py

@@ -6,25 +6,65 @@
 VDAF = "histogram"
 PROCESS_TIMEOUT = 1200  # 20 mins
 
-CONFIG_FILE_NAME = "config.json"     # See example_config.json for the contents and structure of the job config file.
+CONFIG_FILE_NAME = "config.json"  # See example_config.json for the contents and structure of the job config file.
 LOG_FILE_NAME = f"{datetime.now()}-ads-incrementality-dap-collector.log"
 
 COLLECTOR_RESULTS_SCHEMA = [
-    bigquery.SchemaField("collection_start", "DATE", mode="REQUIRED", description="Start date of the collected time window, inclusive."),
-    bigquery.SchemaField("collection_end", "DATE", mode="REQUIRED", description="End date of the collected time window, inclusive."),
-    bigquery.SchemaField("country_codes", "JSON", mode="NULLABLE", description="List of 2-char country codes for the experiment"),
-    bigquery.SchemaField("experiment_slug", "STRING", mode="REQUIRED", description="Slug indicating the experiment."),
-    bigquery.SchemaField("experiment_branch", "STRING", mode="REQUIRED", description="The experiment branch this data is associated with."),
-    bigquery.SchemaField("advertiser", "STRING", mode="REQUIRED", description="Advertiser associated with this experiment."),
-    bigquery.SchemaField("metric", "STRING", mode="REQUIRED", description="Metric collected for this experiment."),
+    bigquery.SchemaField(
+        "collection_start",
+        "DATE",
+        mode="REQUIRED",
+        description="Start date of the collected time window, inclusive.",
+    ),
+    bigquery.SchemaField(
+        "collection_end",
+        "DATE",
+        mode="REQUIRED",
+        description="End date of the collected time window, inclusive.",
+    ),
+    bigquery.SchemaField(
+        "country_codes",
+        "JSON",
+        mode="NULLABLE",
+        description="List of 2-char country codes for the experiment",
+    ),
+    bigquery.SchemaField(
+        "experiment_slug",
+        "STRING",
+        mode="REQUIRED",
+        description="Slug indicating the experiment.",
+    ),
+    bigquery.SchemaField(
+        "experiment_branch",
+        "STRING",
+        mode="REQUIRED",
+        description="The experiment branch this data is associated with.",
+    ),
+    bigquery.SchemaField(
+        "advertiser",
+        "STRING",
+        mode="REQUIRED",
+        description="Advertiser associated with this experiment.",
+    ),
+    bigquery.SchemaField(
+        "metric",
+        "STRING",
+        mode="REQUIRED",
+        description="Metric collected for this experiment.",
+    ),
     bigquery.SchemaField(
         name="value",
         field_type="RECORD",
         mode="REQUIRED",
         fields=[
             bigquery.SchemaField("count", "INT64", mode="NULLABLE"),
             bigquery.SchemaField("histogram", "JSON", mode="NULLABLE"),
-        ]
+        ],
+    ),
+    bigquery.SchemaField(
+        "created_at",
+        "TIMESTAMP",
+        mode="REQUIRED",
+        description="Timestamp for when this row was written.",
     ),
-    bigquery.SchemaField("created_at", "TIMESTAMP", mode="REQUIRED", description="Timestamp for when this row was written.")
 ]