Merge pull request #17220 from Snuffleupagus/pr-17176-followup

timvandermeij · web-flow · commit 87c83ab31c9a · 2023-11-04T15:29:14.000+01:00
Also pause translation when expanding the current outline-item (PR 17176 follow-up)
diff --git a/web/base_tree_viewer.js b/web/base_tree_viewer.js
@@ -161,6 +161,8 @@ class BaseTreeViewer {
     if (!treeItem) {
       return;
     }
+    // Pause translation when expanding the treeItem.
+    this._l10n.pause();
     // Ensure that the treeItem is *fully* expanded, such that it will first of
     // all be visible and secondly that scrolling it into view works correctly.
     let currentNode = treeItem.parentNode;
@@ -171,6 +173,8 @@ class BaseTreeViewer {
       }
       currentNode = currentNode.parentNode;
     }
+    this._l10n.resume();
+
     this._updateCurrentTreeItem(treeItem);
 
     this.container.scrollTo(

Original file line number	Diff line number	Diff line change
`@@ -161,6 +161,8 @@ class BaseTreeViewer {`
`161`	`161`	`if (!treeItem) {`
`162`	`162`	`return;`
`163`	`163`	`}`
	`164`	`+ // Pause translation when expanding the treeItem.`
	`165`	`+ this._l10n.pause();`
`164`	`166`	`// Ensure that the treeItem is fully expanded, such that it will first of`
`165`	`167`	`// all be visible and secondly that scrolling it into view works correctly.`
`166`	`168`	`let currentNode = treeItem.parentNode;`
`@@ -171,6 +173,8 @@ class BaseTreeViewer {`
`171`	`173`	`}`
`172`	`174`	`currentNode = currentNode.parentNode;`
`173`	`175`	`}`
	`176`	`+ this._l10n.resume();`
	`177`	`+`
`174`	`178`	`this._updateCurrentTreeItem(treeItem);`
`175`	`179`
`176`	`180`	`this.container.scrollTo(`