Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/display/editor/annotation_editor_layer.js
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,7 @@ class AnnotationEditorLayer {
}

if (editor.parent && editor.annotationElementId) {
this.#uiManager.addDeletedAnnotationElement(editor.annotationElementId);
this.#uiManager.addDeletedAnnotationElement(editor);
AnnotationEditor.deleteAnnotationElement(editor);
editor.annotationElementId = null;
}
Expand Down
67 changes: 67 additions & 0 deletions test/integration/stamp_editor_spec.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -1824,4 +1824,71 @@ describe("Stamp Editor", () => {
);
});
});

describe("Stamp (move between pages)", () => {
let pages;

beforeEach(async () => {
pages = await loadAndWait(
"firefox_stamp.pdf",
getAnnotationSelector("24R"),
"50"
);
});

afterEach(async () => {
await closePages(pages);
});

it("must move a stamp annotation from page 1 to page 2", async () => {
await Promise.all(
pages.map(async ([browserName, page]) => {
await waitForPageRendered(page, 1);
await waitForPageRendered(page, 2);
await waitForAnnotationEditorLayer(page, 1);
await waitForAnnotationEditorLayer(page, 2);

const modeChangedHandle = await waitForAnnotationModeChanged(page);

await page.click(getAnnotationSelector("24R"), { count: 2 });
await awaitPromise(modeChangedHandle);

const editorSelector = getEditorSelector(0);
await waitForSelectedEditor(page, editorSelector);

await scrollIntoView(
page,
`.page[data-page-number="2"] .annotationEditorLayer`
);

const editorRect = await getRect(page, editorSelector);
const page2Rect = await getRect(
page,
`.page[data-page-number="2"] .annotationEditorLayer`
);

const deltaX =
page2Rect.x +
page2Rect.width / 2 -
(editorRect.x + editorRect.width / 2);
const deltaY =
page2Rect.y +
page2Rect.height / 3 -
(editorRect.y + editorRect.height / 2);

await dragAndDrop(page, editorSelector, [[deltaX, deltaY]], 10);

await page.waitForFunction(
sel => {
const editorDiv = document.querySelector(sel);
const pageDiv = editorDiv?.closest(".page");
return pageDiv?.getAttribute("data-page-number") === "2";
},
{},
editorSelector
);
})
);
});
});
});