TSL: `onDispose` listeners on PMREM textures grow indefinitely

[shotamatsuda]

Description

Very similar to #31600, the event listeners on PMREMNode's dispose event grow indefinitely. webgpu_cubemap_dynamic also reproduces this issue.

The code in question would be https://github.com/mrdoob/three.js/blob/r180/src/renderers/common/Textures.js#L349, which unconditionally adds event listener without checking whether it has already been added.

This prevents WebGPURenderer from running for more than an hour, because it has a significant impact on frame performance (presumably due to operations on a very large array in EventDispatcher).

Reproduction steps

1. Open webgpu_cubemap_dynamic in Chrome (it should also reproduce in other browsers).
2. Open the developer console, and select the “Memory” tab.
3. After running it for a few minutes, take a heap snapshot, navigate to Array > Array, sort by "Retained Size", and look the top entries (first and second).

Code

A minimal reproduction follows. You can inspect the leak in the same steps as above.

const cubeRT = new WebGLCubeRenderTarget(64)
const cubeCamera = new CubeCamera(1, 1000, cubeRT)
const cubeScene = new Scene()
const material = new MeshStandardNodeMaterial({
  envMap: cubeRT.texture
})

const mesh = new Mesh(new PlaneGeometry(), material)
const camera = new PerspectiveCamera()
const scene = new Scene().add(mesh)

void renderer.setAnimationLoop(() => {
  cubeCamera.update(renderer, cubeScene)
  void renderer.render(scene, camera)
})

Live example

https://jsfiddle.net/shotamatsuda/0Lfvz3yt/ (this directly counts the number of listeners)

Screenshots

No response

Version

r180

Device

Desktop

Browser

Chrome

OS

MacOS

[Mugen87]

The code in question would be https://github.com/mrdoob/three.js/blob/r180/src/renderers/common/Textures.js#L349, which unconditionally adds event listener without checking whether it has already been added.

At least webgpu_cubemap_dynamic does enter this code block during rendering. I can't currently open your fiddle since jsfiddle.net seems not to respond in general right now. Do you mind checking if the root cause is somewhere else in the code?

[shotamatsuda]

At least webgpu_cubemap_dynamic does [not] enter this code block during rendering.

You are right. I checked it again and the code in question is: https://github.com/mrdoob/three.js/blob/r180/src/renderers/common/Sampler.js#L63

So, it indeed tries to remove the previous listener, but similarly in #31600, removeEventListener fails because onDispose is recreated every call. It will be an easy fix and I can make a PR in this case.

[Mugen87]

Great! Feel free to file a PR then 😊 .