refactor(iroh): add --start option to CLI commands (#1802)

## Description

Changes to CLI commands:

* All RPC commands now have a `--start` option that starts a node, runs
the command, and then shuts down the node
* `iroh get` is now `iroh blob get`, and needs `--start` flag to run
standalone
* `iroh start SOURCE` is now `iroh start --add SOURCE`
* Improvements to the node startup code and error handling

## Notes and open questions

We could remove the `--add SOURCE` option from `iroh start` if there was
a way to to keep running the node after starting it with a command.
Could also be something like an `--exec` option. But let's leave that to
a followup.

---------

Co-authored-by: Franz Heinzmann (Frando) <[email protected]>
Co-authored-by: Asmir Avdicevic <[email protected]>

Author: 3 people

iroh-bytes/src/provider.rs

@@ -1,5 +1,6 @@
 //! The server side API
 use std::fmt::Debug;
+use std::path::PathBuf;
 use std::sync::Arc;
 use std::time::Duration;
 
@@ -209,7 +210,7 @@ pub enum DownloadProgress {
         /// The size of the entry in bytes.
         size: u64,
         /// The path to the file where the data is exported.
-        target: String,
+        target: PathBuf,
     },
     /// We have made progress exporting the data.
     ///

iroh-net/src/netcheck/reportgen.rs

@@ -741,18 +741,19 @@ async fn run_probe(
     debug!("starting probe");
 
     let (would_help_tx, would_help_rx) = oneshot::channel();
-    reportstate
+    if let Err(err) = reportstate
         .send(Message::ProbeWouldHelp(
             probe.clone(),
             derp_node.clone(),
             would_help_tx,
         ))
         .await
-        .map_err(|err| {
-            error!("Failed to check if probe would help: {err:#}");
-            err
-        })
-        .map_err(|err| ProbeError::AbortSet(err.into(), probe.clone()))?;
+    {
+        // this happens on shutdown or if the report is already finished
+        debug!("Failed to check if probe would help: {err:#}");
+        return Err(ProbeError::AbortSet(err.into(), probe.clone()));
+    }
+
     if !would_help_rx.await.map_err(|_| {
         ProbeError::AbortSet(
             anyhow!("ReportCheck actor dropped sender while waiting for ProbeWouldHelp response"),