Skip to content

Commit 995cf5f

Browse files
committed
don't handle ice candidate messages
1 parent 4ef3732 commit 995cf5f

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

examples/libpeer/src/libpeer_connection.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ PeerConnectionPtr WebrtcConnection::create(
1818

1919
auto conn = std::make_shared<WebrtcConnection>(device, channel, transport);
2020
conn->init();
21-
conn->pcConfig_ = {};
21+
memset(&conn->pcConfig_, 0, sizeof(conn->pcConfig_));
2222
return conn;
2323
}
2424

@@ -123,12 +123,12 @@ void WebrtcConnection::handleMessage(nrtc::util::WebrtcSignalingMessage& msg) {
123123
if (msg.isDescription()) {
124124
auto desc = msg.getDescription();
125125
auto type = desc.type == "offer" ? SDP_TYPE_OFFER : SDP_TYPE_ANSWER;
126+
NPLOGI << desc.sdp;
126127
peer_connection_set_remote_description(pc_, desc.sdp.c_str(), type);
127128
}
128129

129130
if (msg.isCandidate()) {
130-
std::string cand = msg.getCandidate().candidate;
131-
peer_connection_add_ice_candidate(pc_, cand.data());
131+
NPLOGE << "Received candidate message even though that shouldnt be possible: " << msg.getCandidate().candidate;
132132
}
133133
}
134134

@@ -152,7 +152,7 @@ void WebrtcConnection::onIceCandidate(char* description, void* userdata) {
152152
nrtc::util::SignalingCandidate signalingCandidate(cand);
153153

154154
// @TODO: Probably not correct to just set "0" here.
155-
signalingCandidate.setSdpMid("0");
155+
signalingCandidate.setSdpMid("video");
156156

157157
conn->sendSignalingMessage(
158158
nrtc::util::WebrtcSignalingMessage(signalingCandidate));

examples/libpeer/src/main.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717

1818
using std::string;
1919

20+
nabto::example::PeerConnectionPtr conn = nullptr;
21+
2022
int main() {
2123
static plog::ColorConsoleAppender<plog::TxtFormatter> consoleAppender;
2224
nabto::webrtc::util::initLogger(plog::Severity::debug, &consoleAppender);
@@ -47,8 +49,7 @@ int main() {
4749
return sharedSecret;
4850
});
4951

50-
auto conn = nabto::example::WebrtcConnection::create(device, channel,
51-
transport);
52+
conn = nabto::example::WebrtcConnection::create(device, channel, transport);
5253
});
5354

5455
device->start();

0 commit comments

Comments
 (0)