fix linting

Author: Thomas

sdk/.clang-tidy

@@ -25,3 +25,4 @@ HeaderFilterRegex: '.*'
 
 CheckOptions:
   readability-function-cognitive-complexity.IgnoreMacros: true
+  misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic: true

sdk/src/signaling_util/message_transport/include/nabto/webrtc/util/message_transport.hpp

@@ -70,7 +70,7 @@ class SignalingDescription {
    * @param descType type of the description, typically "offer" or "answer"
    * @param descSdp SDP representation of the description.
    */
-  SignalingDescription(const std::string& descType, const std::string& descSdp);
+  SignalingDescription(std::string descType, std::string descSdp);
 
   /**
    * Convert the description to JSON format following the network protocol.
@@ -101,7 +101,7 @@ class SignalingCandidate {
    *
    * @param cand The string representation of the candidate.
    */
-  SignalingCandidate(const std::string& cand);
+  explicit SignalingCandidate(std::string cand);
 
   /**
    * Set the optional SDP MID value of a candidate.
@@ -146,7 +146,7 @@ class SignalingCandidate {
    * Optional SDP M Line Index of the candidate. If this is `<0` it means the
    * value does not exist.
    */
-  int sdpMLineIndex;
+  int sdpMLineIndex{-1};
 
   /**
    * Optional Username Fragment of the candidate. If this is empty, it means the
@@ -179,14 +179,14 @@ class WebrtcSignalingMessage {
    *
    * @param description The description to construct with.
    */
-  WebrtcSignalingMessage(SignalingDescription description);
+  explicit WebrtcSignalingMessage(const SignalingDescription& description);
 
   /**
    * Construct a WebRTC Signaling message from a SignalingCandidate.
    *
    * @param candidate The candidate to construct with.
    */
-  WebrtcSignalingMessage(SignalingCandidate candidate);
+  explicit WebrtcSignalingMessage(const SignalingCandidate& candidate);
 
   /**
    * Check if the message is a SignalingDescription.

sdk/src/signaling_util/message_transport/src/message_transport.cpp

@@ -3,6 +3,12 @@
 #include <nabto/webrtc/device.hpp>
 #include <nabto/webrtc/util/message_transport.hpp>
 
+#include <nlohmann/json.hpp>
+#include <nlohmann/json_fwd.hpp>
+
+#include <memory>
+#include <stdexcept>
+#include <string>
 #include <utility>
 
 namespace nabto {
@@ -25,11 +31,10 @@ MessageTransportPtr MessageTransportFactory::createNoneTransport(
 }
 
 // SIGNALING DESCRIPTION START
-SignalingDescription::SignalingDescription(const std::string& descType,
-                                           const std::string& descSdp) {
-  type = descType;
-  sdp = descSdp;
-}
+// NOLINTNEXTLINE(bugprone-easily-swappable-parameters)
+SignalingDescription::SignalingDescription(std::string descType,
+                                           std::string descSdp)
+    : type(std::move(descType)), sdp(std::move(descSdp)) {}
 
 nlohmann::json SignalingDescription::toJson() {
   nlohmann::json desc = {{"type", type}, {"sdp", sdp}};
@@ -42,9 +47,8 @@ nlohmann::json SignalingDescription::toJson() {
 }
 
 // SIGNALING CANDIDATE START
-SignalingCandidate::SignalingCandidate(const std::string& cand) {
-  candidate = cand;
-}
+SignalingCandidate::SignalingCandidate(std::string cand)
+    : candidate(std::move(cand)) {}
 
 void SignalingCandidate::setSdpMid(const std::string& mid) { sdpMid = mid; }
 void SignalingCandidate::setSdpMLineIndex(int index) { sdpMLineIndex = index; }
@@ -74,10 +78,11 @@ nlohmann::json SignalingCandidate::toJson() {
 
 // SIGNALING MESSAGE START
 
-WebrtcSignalingMessage::WebrtcSignalingMessage(SignalingDescription desc) {
+WebrtcSignalingMessage::WebrtcSignalingMessage(
+    const SignalingDescription& desc) {
   description_ = std::make_unique<SignalingDescription>(desc);
 }
-WebrtcSignalingMessage::WebrtcSignalingMessage(SignalingCandidate cand) {
+WebrtcSignalingMessage::WebrtcSignalingMessage(const SignalingCandidate& cand) {
   candidate_ = std::make_unique<SignalingCandidate>(cand);
 }
 
@@ -90,10 +95,10 @@ bool WebrtcSignalingMessage::isCandidate() const {
 }
 
 SignalingDescription WebrtcSignalingMessage::getDescription() const {
-  return *(description_.get());
+  return *description_;
 }
 SignalingCandidate WebrtcSignalingMessage::getCandidate() const {
-  return *(candidate_.get());
+  return *candidate_;
 }
 
 WebrtcSignalingMessage WebrtcSignalingMessage::fromJson(
@@ -102,7 +107,7 @@ WebrtcSignalingMessage WebrtcSignalingMessage::fromJson(
   if (type == "DESCRIPTION") {
     auto descType = jsonMessage.at("description").at("type").get<std::string>();
     auto sdp = jsonMessage.at("description").at("sdp").get<std::string>();
-    SignalingDescription desc(descType, sdp);
+    const SignalingDescription desc(descType, sdp);
     return WebrtcSignalingMessage(desc);
   }
   if (type == "CANDIDATE") {