Merge pull request #631 from ripienaar/interest_pager_direct

Ensure direct gets are used for viewing interest streams

Author: ripienaar

go.mod

@@ -10,7 +10,7 @@ require (
 	github.com/jedib0t/go-pretty/v6 v6.6.6
 	github.com/klauspost/compress v1.18.0
 	github.com/nats-io/jwt/v2 v2.7.3
-	github.com/nats-io/nats-server/v2 v2.11.0-dev.0.20250220020605-cad5114b5064
+	github.com/nats-io/nats-server/v2 v2.11.0-dev.0.20250220145551-7e8c334ec33e
 	github.com/nats-io/nats.go v1.39.1
 	github.com/nats-io/nkeys v0.4.10
 	github.com/nats-io/nuid v1.0.1

go.sum

@@ -33,8 +33,8 @@ github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 h1:C3w9PqII01/Oq
 github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822/go.mod h1:+n7T8mK8HuQTcFwEeznm/DIxMOiR9yIdICNftLE1DvQ=
 github.com/nats-io/jwt/v2 v2.7.3 h1:6bNPK+FXgBeAqdj4cYQ0F8ViHRbi7woQLq4W29nUAzE=
 github.com/nats-io/jwt/v2 v2.7.3/go.mod h1:GvkcbHhKquj3pkioy5put1wvPxs78UlZ7D/pY+BgZk4=
-github.com/nats-io/nats-server/v2 v2.11.0-dev.0.20250220020605-cad5114b5064 h1:4ylzrue/HOkfgV+ImULDLj7Q6EXlmdeGYQcqwcMjOoU=
-github.com/nats-io/nats-server/v2 v2.11.0-dev.0.20250220020605-cad5114b5064/go.mod h1:rx54jecOLXzMFsVMhsVcUX74wDWWAbU98zqj6gIkvOY=
+github.com/nats-io/nats-server/v2 v2.11.0-dev.0.20250220145551-7e8c334ec33e h1:vQ417szzp1N+Seq6/Ytf/9lCH6OQSw9WCCd8U8plgSk=
+github.com/nats-io/nats-server/v2 v2.11.0-dev.0.20250220145551-7e8c334ec33e/go.mod h1:rx54jecOLXzMFsVMhsVcUX74wDWWAbU98zqj6gIkvOY=
 github.com/nats-io/nats.go v1.39.1 h1:oTkfKBmz7W047vRxV762M67ZdXeOtUgvbBaNoQ+3PPk=
 github.com/nats-io/nats.go v1.39.1/go.mod h1:MgRb8oOdigA6cYpEPhXJuRVH6UE/V4jblJ2jQ27IXYM=
 github.com/nats-io/nkeys v0.4.10 h1:glmRrpCmYLHByYcePvnTBEAwawwapjCPMjy2huw20wc=

stream_pager.go

@@ -101,12 +101,18 @@ func (p *StreamPager) start(stream *Stream, mgr *Manager, opts ...PagerOption) e
 
 	var err error
 
-	if p.stream.Retention() == api.WorkQueuePolicy && !p.stream.DirectAllowed() {
-		return fmt.Errorf("work queue retention streams can only be paged if direct access is allowed")
+	if !p.stream.DirectAllowed() {
+		if p.stream.Retention() == api.WorkQueuePolicy {
+			return fmt.Errorf("work queue retention streams can only be paged if direct access is allowed")
+		}
+
+		if p.stream.Retention() == api.InterestPolicy {
+			return fmt.Errorf("interest retention streams can only be paged if direct access is allowed")
+		}
 	}
 
 	// for now only on WQ because its slow, until there is a batch mode direct request
-	p.useDirect = p.stream.Retention() == api.WorkQueuePolicy && p.stream.DirectAllowed()
+	p.useDirect = p.stream.Retention() == api.WorkQueuePolicy || p.stream.Retention() == api.InterestPolicy
 
 	p.q = make(chan *nats.Msg, p.pageSize)
 	p.sub, err = mgr.nc.ChanSubscribe(mgr.nc.NewRespInbox(), p.q)