Skip to content

Add cli version to audit gather metadata #1498

@alexbozhenko

Description

@alexbozhenko

Proposed change

When gather was part of the cli, we used to set version:
61c725c#diff-452e58ada64db9f1034b213cadb3affe99b9bda948000988e1255dd007648146L691

we do not do not set any version anymore:
https://github.com/nats-io/jsm.go/blob/fa5c81909624897f9180f942a9ec8bcf8757b12a/audit/gather/gather.go#L273-L279

So we get empty version inside the archive:

# jq '.cli_version' audit_gather_metadata.json
""

Can we pass the version through this call as argument(or part of the config struct?)

return gatherer.Gather(nc, c.config)

So we can thread it to the metadata?

Use case

We need to know version of the cli that was used to generated gather archive, e.g. when something does not look right in the output and we need to fiugre out why.

Contribution

I can.

Metadata

Metadata

Assignees

No one assigned

    Labels

    proposalEnhancement idea or proposal

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions