fix: OpenAPI attributes responses not being processed #2627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mio#2593) ## Description Should make it possible to atleast automate versioning for older versions (4.x) 👀 nelmio#2591 (comment) Uses new feature from googleapis/release-please-action#1121 ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [x] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`)
## Description Implements https://github.com/korthout/backport-action to create a backport ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [x] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`)
…#2595) ### This is an automated backport of nelmio#2588 to branch `4.x`. > [!CAUTION] > **Do not modify this pull request.** ## Description Fixes nelmio#2587 Related to BC introduced in zircote/swagger-php#1829 (issue: zircote/swagger-php#1832) ## What type of PR is this? (check all applicable) - [x] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`) Co-authored-by: Djordy Koert <[email protected]>
This reverts commit b39d05f.
🤖 I have created a release *beep* *boop* --- ## [4.38.3](nelmio/NelmioApiDocBundle@v4.38.2...v4.38.3) (2025-11-12) ### Bug Fixes * remove unused `TypesTrait` [Backport [nelmio#2588](nelmio#2588) to 4.x] ([nelmio#2595](nelmio#2595)) ([12a01d2](nelmio@12a01d2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 59214f6.
to 4.x] (nelmio#2602) ### This is an automated backport of nelmio#2601 to branch `4.x`. > [!CAUTION] > **Do not modify this pull request.** ## Description should fix backport PR's not triggering CI workflow ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [x] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`) Co-authored-by: Djordy Koert <[email protected]>
…#2568 to 4.x] (nelmio#2604) ### This is an automated backport of nelmio#2568 to branch `4.x`. > [!CAUTION] > **Do not modify this pull request.** ## Description It seems that version [`5.5.0`](https://github.com/zircote/swagger-php/releases/tag/5.5.0) introduced a bug. Reported in zircote/swagger-php#1823 zircote/swagger-php#1823 ## What type of PR is this? (check all applicable) - [x] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [x] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`) Co-authored-by: Djordy Koert <[email protected]>
…elmio#2603) ### This is an automated backport of nelmio#2598 to branch `4.x`. > [!CAUTION] > **Do not modify this pull request.** ## Description Fixes zircote/swagger-php#1837 ## What type of PR is this? (check all applicable) - [x] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`) Co-authored-by: Djordy Koert <[email protected]>
This reverts commit 248dd59.
🤖 I have created a release *beep* *boop* --- ## [4.38.4](nelmio/NelmioApiDocBundle@v4.38.3...v4.38.4) (2025-11-13) ### Bug Fixes * swagger-php 5.7.0 compatatiblity [Backport [nelmio#2598](nelmio#2598) to 4.x] ([nelmio#2603](nelmio#2603)) ([ef3ba7d](nelmio@ef3ba7d)) * **swagger-php:** conflict with broken version 5.5.0 [Backport [nelmio#2568](nelmio#2568) to 4.x] ([nelmio#2604](nelmio#2604)) ([82e24b4](nelmio@82e24b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…o#2608) ### This is an automated backport of nelmio#2607 to branch `4.x`. > [!CAUTION] > **Do not modify this pull request.** ## Description Ignore insecure dependency, this is currently causing CI to fail https://symfony.com/blog/cve-2025-64500-incorrect-parsing-of-path-info-can-lead-to-limited-authorization-bypass > Problem 1 - Root composer.json requires symfony/http-foundation ^6.4 || ^7.1, found symfony/http-foundation[v6.4.0, ..., v6.4.29, v7.1.0, ..., v7.3.7] but these were not loaded, because they are affected by security advisories. To ignore the advisories, add ("PKSA-365x-2zjk-pt47") to the audit "ignore" config. To turn the feature off entirely, you can set "block-insecure" to false in your "audit" config. ## What type of PR is this? (check all applicable) - [ ] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [x] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`) Co-authored-by: Djordy Koert <[email protected]>
…2615) ## Description Makes it impossible to enable `type_info` config option on Symfony 6. Closes nelmio#2614 ## What type of PR is this? (check all applicable) - [x] Bug Fix - [ ] Feature - [ ] Refactor - [ ] Deprecation - [ ] Breaking Change - [ ] Documentation Update - [ ] CI ## Checklist - [ ] I have made corresponding changes to the documentation (`docs/`) - [ ] I have made corresponding changes to the changelog (`CHANGELOG.md`)
🤖 I have created a release *beep* *boop* --- ## [4.38.5](nelmio/NelmioApiDocBundle@v4.38.4...v4.38.5) (2025-11-14) ### Bug Fixes * **configuration:** validate `type_info` option on Symfony 6 ([nelmio#2615](nelmio#2615)) ([b625aa6](nelmio@b625aa6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
The OpenApiPhpDescriber wasn't handling Post/Get/Put/Delete/Patch attributes properly, so their responses weren't being merged into the spec. Also fixed DefaultDescriber adding default responses even when specific ones were already defined. Now attributes like #[OA\Post] work correctly and we don't get default responses overriding the actual ones.
hectorprats
changed the title
Collaborator
|
I think #2629 is the correct PR, right? 🤔 |
Author
|
Yes, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where OpenAPI attributes responses were not being processed correctly.
Changes
OpenApiPhpDescriberDefaultDescriberCommits