Merge pull request #1155 from jbpionnier/refactor_clean_as_any

refactor(nestjs) code style, clean "as any"

Author: kamilmysliwiec

packages/common/cache/cache.providers.ts

@@ -11,7 +11,7 @@ export function createCacheManager(): Provider {
       const cacheManager = loadPackage('cache-manager', 'CacheModule');
       const memoryCache = cacheManager.caching({
         ...defaultCacheOptions,
-        ...((options || {}) as any),
+        ...(options || {}),
       });
       return memoryCache;
     },

packages/common/decorators/http/create-route-param-metadata.decorator.ts

@@ -63,7 +63,7 @@ export function createParamDecorator(
         index,
         factory,
         paramData,
-        ...((paramPipes as any) as PipeTransform[]),
+        ...(paramPipes as PipeTransform[]),
       ),
       target.constructor,
       key,

packages/common/test/cache/cache.module.ts

@@ -8,7 +8,7 @@ describe('CacheModule', () => {
       const options = {
         test: 'test',
       };
-      const dynamicModule = CacheModule.register(options as any);
+      const dynamicModule = CacheModule.register(options);
 
       expect(dynamicModule.providers).to.have.length(1);
       expect(dynamicModule.imports).to.be.empty;

packages/common/test/pipes/parse-int.pipe.spec.ts

@@ -12,14 +12,14 @@ describe('ParseIntPipe', () => {
     describe('when validation passes', () => {
       it('should return number', async () => {
         const num = '3';
-        expect(await target.transform(num, {} as any)).to.equal(
+        expect(await target.transform(num, {} as ArgumentMetadata)).to.equal(
           parseInt(num, 10),
         );
       });
     });
     describe('when validation fails', () => {
       it('should throw an error', async () => {
-        return expect(target.transform('123abc', {} as any)).to.be.rejected;
+        return expect(target.transform('123abc', {} as ArgumentMetadata)).to.be.rejected;
       });
     });
   });

packages/core/adapters/express-adapter.ts

@@ -76,27 +76,27 @@ export class ExpressAdapter implements HttpServer {
   }
 
   setErrorHandler(handler: Function) {
-    return this.use(handler as any);
+    return this.use(handler);
   }
 
   setNotFoundHandler(handler: Function) {
-    return this.use(handler as any);
+    return this.use(handler);
   }
 
   setHeader(response, name: string, value: string) {
     return response.set(name, value);
   }
 
   getHttpServer<T = any>(): T {
-    return this.httpServer as any as T;
+    return this.httpServer as T;
   }
 
   setHttpServer(httpServer) {
     this.httpServer = httpServer;
   }
 
   getInstance<T = any>(): T {
-    return this.instance as any as T;
+    return this.instance as T;
   }
 
   close() {

packages/core/adapters/fastify-adapter.ts

@@ -81,11 +81,11 @@ export class FastifyAdapter {
   }
 
   getHttpServer<T = any>(): T {
-    return this.instance.server as any as T;
+    return this.instance.server as T;
   }
 
   getInstance<T = any>(): T {
-    return this.instance as any as T;
+    return this.instance as T;
   }
 
   register(...args) {

packages/core/exceptions/base-exception-filter-context.ts

@@ -52,7 +52,7 @@ export class BaseExceptionFilterContext extends ContextCreator {
     if (!module) {
       return undefined;
     }
-    return module.injectables.get((filter as any).name);
+    return module.injectables.get(filter.name);
   }
 
   public reflectCatchExceptions(instance: ExceptionFilter): Type<any>[] {

packages/core/exceptions/base-exception-filter.ts

@@ -27,7 +27,7 @@ export class BaseExceptionFilter<T = any> implements ExceptionFilter<T> {
           exception.stack,
         );
       }
-      return BaseExceptionFilter.logger.error(exception as any);
+      return BaseExceptionFilter.logger.error(exception);
     }
     const res = exception.getResponse();
     const message = isObject(res)

packages/core/guards/guards-context-creator.ts

@@ -60,7 +60,7 @@ export class GuardsContextCreator extends ContextCreator {
     if (!module) {
       return undefined;
     }
-    return module.injectables.get((guard as any).name);
+    return module.injectables.get(guard.name);
   }
 
   public getGlobalMetadata<T extends any[]>(): T {

packages/core/interceptors/interceptors-context-creator.ts

@@ -65,7 +65,7 @@ export class InterceptorsContextCreator extends ContextCreator {
     if (!module) {
       return undefined;
     }
-    return module.injectables.get((metatype as any).name);
+    return module.injectables.get(metatype.name);
   }
 
   public getGlobalMetadata<T extends any[]>(): T {