fix: handle empty cases in edge bundling (#6659)

Co-authored-by: Mateusz Bocian <[email protected]>

Author: pieh

packages/build/src/plugins_core/edge_functions/index.ts

@@ -72,7 +72,24 @@ const coreStep = async function ({
 
   const sourcePaths = [...generatedFunctionPaths, srcPath].filter(Boolean) as string[]
 
-  logFunctions({ frameworksAPISrcPath, internalSrcDirectory, internalSrcPath, logs, srcDirectory, srcPath })
+  const [userFunctionsSrcExists, userFunctions, internalFunctions, frameworkFunctions] = await Promise.all([
+    srcPath ? pathExists(srcPath) : Promise.resolve(false),
+    srcPath ? find([srcPath]) : Promise.resolve([]),
+    find([internalSrcPath]),
+    frameworksAPISrcPath ? find([frameworksAPISrcPath]) : Promise.resolve([]),
+  ])
+
+  logFunctionsToBundle({
+    logs,
+    userFunctions: userFunctions.map(({ name }) => name),
+    userFunctionsSrc: srcDirectory,
+    userFunctionsSrcExists,
+    internalFunctions: internalFunctions.map(({ name }) => name),
+    internalFunctionsSrc: internalSrcDirectory,
+    frameworkFunctions: frameworkFunctions.map(({ name }) => name),
+    type: 'Edge Functions',
+    generatedFunctions: {},
+  })
 
   // If we're running in buildbot, we set the Deno cache dir to a directory
   // that is persisted between builds.
@@ -86,6 +103,10 @@ const coreStep = async function ({
     // no-op
   }
 
+  if (userFunctions.length === 0 && internalFunctions.length === 0 && frameworkFunctions.length === 0) {
+    return {}
+  }
+
   let vendorDirectory: string | undefined
 
   // If we're building locally, set a vendor directory in `internalSrcPath`.
@@ -175,41 +196,6 @@ const hasEdgeFunctionsDirectories = async function ({
   return await pathExists(frameworkFunctionsSrc)
 }
 
-const logFunctions = async ({
-  frameworksAPISrcPath,
-  internalSrcDirectory,
-  internalSrcPath,
-  logs,
-  srcDirectory: userFunctionsSrc,
-  srcPath,
-}: {
-  frameworksAPISrcPath?: string
-  internalSrcDirectory: string
-  internalSrcPath: string
-  logs: any
-  srcDirectory?: string
-  srcPath?: string
-}): Promise<void> => {
-  const [userFunctionsSrcExists, userFunctions, internalFunctions, frameworkFunctions] = await Promise.all([
-    srcPath ? pathExists(srcPath) : Promise.resolve(false),
-    srcPath ? find([srcPath]) : Promise.resolve([]),
-    find([internalSrcPath]),
-    frameworksAPISrcPath ? find([frameworksAPISrcPath]) : Promise.resolve([]),
-  ])
-
-  logFunctionsToBundle({
-    logs,
-    userFunctions: userFunctions.map(({ name }) => name),
-    userFunctionsSrc,
-    userFunctionsSrcExists,
-    internalFunctions: internalFunctions.map(({ name }) => name),
-    internalFunctionsSrc: internalSrcDirectory,
-    frameworkFunctions: frameworkFunctions.map(({ name }) => name),
-    type: 'Edge Functions',
-    generatedFunctions: {},
-  })
-}
-
 export const bundleEdgeFunctions = {
   event: 'onBuild',
   coreStep,

packages/build/tests/edge_functions/fixtures/functions_empty_directory/.netlify/edge-functions/.gitkeep

@@ -0,0 +1,4 @@
+{
+  "functions": [],
+  "version": 1
+}

packages/build/tests/edge_functions/fixtures/functions_empty_manifest/.netlify/edge-functions/manifest.json

@@ -289,3 +289,31 @@ test.serial(
     ])
   },
 )
+
+test('skip bundling when edge function directories exist, contain no functions', async (t) => {
+  await new Fixture('./fixtures/functions_empty_directory').runWithBuild()
+
+  const manifestPath = join(
+    FIXTURES_DIR,
+    'functions_empty_directory',
+    '.netlify',
+    'edge-functions-dist',
+    'manifest.json',
+  )
+
+  t.false(await pathExists(manifestPath))
+})
+
+test('skip bundling when edge function directories exist, contain no functions, contain empty manifest', async (t) => {
+  await new Fixture('./fixtures/functions_empty_manifest').runWithBuild()
+
+  const manifestPath = join(
+    FIXTURES_DIR,
+    'functions_empty_manifest',
+    '.netlify',
+    'edge-functions-dist',
+    'manifest.json',
+  )
+
+  t.false(await pathExists(manifestPath))
+})