fix: ensure we pass an ArrayBufferLike to blobStore.set and not a NodeJS Buffer

JakeChampion · JakeChampion · commit ee52833ef05b · 2024-12-06T18:30:44.000Z
diff --git a/packages/build/src/plugins_core/blobs_upload/index.ts b/packages/build/src/plugins_core/blobs_upload/index.ts
@@ -72,7 +72,8 @@ const coreStep: CoreStepFunction = async function ({
         systemLog(`Uploading blob ${key}`)
 
         const { data, metadata } = await getFileWithMetadata(key, contentPath, metadataPath)
-        await blobStore.set(key, data, { metadata })
+        const buffer = new Uint8Array(data.buffer, data.byteOffset, data.length)
+        await blobStore.set(key, buffer.buffer, { metadata })
       },
       { concurrency: 10 },
     )
diff --git a/packages/build/src/plugins_core/dev_blobs_upload/index.ts b/packages/build/src/plugins_core/dev_blobs_upload/index.ts
@@ -77,7 +77,8 @@ const coreStep: CoreStepFunction = async function ({
           log(logs, `- Uploading blob ${key}`, { indent: true })
         }
         const { data, metadata } = await getFileWithMetadata(key, contentPath, metadataPath)
-        await blobStore.set(key, data, { metadata })
+        const buffer = new Uint8Array(data.buffer, data.byteOffset, data.length)
+        await blobStore.set(key, buffer.buffer, { metadata })
       },
       { concurrency: 10 },
     )

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,8 @@ const coreStep: CoreStepFunction = async function ({`
`72`	`72`	systemLog(`Uploading blob ${key}`)
`73`	`73`
`74`	`74`	`const { data, metadata } = await getFileWithMetadata(key, contentPath, metadataPath)`
`75`		`- await blobStore.set(key, data, { metadata })`
	`75`	`+ const buffer = new Uint8Array(data.buffer, data.byteOffset, data.length)`
	`76`	`+ await blobStore.set(key, buffer.buffer, { metadata })`
`76`	`77`	`},`
`77`	`78`	`{ concurrency: 10 },`
`78`	`79`	`)`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,8 @@ const coreStep: CoreStepFunction = async function ({`
`77`	`77`	log(logs, `- Uploading blob ${key}`, { indent: true })
`78`	`78`	`}`
`79`	`79`	`const { data, metadata } = await getFileWithMetadata(key, contentPath, metadataPath)`
`80`		`- await blobStore.set(key, data, { metadata })`
	`80`	`+ const buffer = new Uint8Array(data.buffer, data.byteOffset, data.length)`
	`81`	`+ await blobStore.set(key, buffer.buffer, { metadata })`
`81`	`82`	`},`
`82`	`83`	`{ concurrency: 10 },`
`83`	`84`	`)`