Skip to content

Commit 02e0dff

Browse files
lhtinbenchislett
authored andcommitted
[BugFix][Core] Fix error when enable async-scheduling in multi-node env (vllm-project#25887)
Signed-off-by: Lehua Ding <[email protected]> Signed-off-by: Lehua Ding <[email protected]> Co-authored-by: Benjamin Chislett <[email protected]>
1 parent 3be5218 commit 02e0dff

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

vllm/engine/arg_utils.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1440,13 +1440,6 @@ def create_engine_config(
14401440
)
14411441

14421442
if self.async_scheduling:
1443-
# Async scheduling does not work with the uniprocess backend.
1444-
if self.distributed_executor_backend is None:
1445-
self.distributed_executor_backend = "mp"
1446-
logger.info(
1447-
"Defaulting to mp-based distributed executor "
1448-
"backend for async scheduling."
1449-
)
14501443
if self.pipeline_parallel_size > 1:
14511444
raise ValueError(
14521445
"Async scheduling is not supported with pipeline-parallel-size > 1."
@@ -1503,6 +1496,15 @@ def create_engine_config(
15031496
_api_process_rank=self._api_process_rank,
15041497
)
15051498

1499+
if self.async_scheduling and (
1500+
parallel_config.distributed_executor_backend not in ("mp", "uni")
1501+
):
1502+
raise ValueError(
1503+
"Currently, async scheduling only supports `mp` or `uni` "
1504+
"distributed executor backend, but you choose "
1505+
f"`{parallel_config.distributed_executor_backend}`."
1506+
)
1507+
15061508
speculative_config = self.create_speculative_config(
15071509
target_model_config=model_config,
15081510
target_parallel_config=parallel_config,

0 commit comments

Comments
 (0)