Code Review

Author: nowjean

apis/v1alpha2/nginxproxy_types.go

@@ -450,7 +450,9 @@ type HPASpec struct {
 	TargetMemoryUtilizationPercentage *int32 `json:"targetMemoryUtilizationPercentage,omitempty"`
 
 	// Minimum number of replicas.
-	MinReplicas *int32 `json:"minReplicas"`
+	//
+	// +optional
+	MinReplicas *int32 `json:"minReplicas,omitempty"`
 
 	// Maximum number of replicas.
 	MaxReplicas int32 `json:"maxReplicas"`

config/crd/bases/gateway.nginx.org_nginxproxies.yaml

@@ -4120,7 +4120,6 @@ spec:
                         required:
                         - enabled
                         - maxReplicas
-                        - minReplicas
                         type: object
                         x-kubernetes-validations:
                         - message: at least one metric must be specified when autoscaling

deploy/crds.yaml

@@ -4705,7 +4705,6 @@ spec:
                         required:
                         - enabled
                         - maxReplicas
-                        - minReplicas
                         type: object
                         x-kubernetes-validations:
                         - message: at least one metric must be specified when autoscaling