Skip to content

Commit 93486eb

Browse files
committed
Remove key from secretRef
1 parent 8526c7f commit 93486eb

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

docs/proposals/authentication-filter.md

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ type AuthenticationFilterSpec struct {
121121
//
122122
// +optional
123123
JWT *JWTAuth `json:"jwt,omitempty"`
124-
}
124+
}
125125

126126
// AuthType defines the authentication mechanism.
127127
// +kubebuilder:validation:Enum=Basic;JWT
@@ -483,7 +483,6 @@ spec:
483483
basic:
484484
secretRef:
485485
name: basic-auth-users # Secret containing htpasswd data
486-
key: htpasswd # key within the Secret
487486
realm: "Restricted" # Optional. Helps with logging
488487
onFailure: # Optional. These setting may be defaults.
489488
statusCode: 401
@@ -604,7 +603,6 @@ spec:
604603
file:
605604
secretRef:
606605
name: jwt-keys-secure
607-
key: jwks.json
608606
keyCache: 10m # Optional cache time for keys (auth_jwt_key_cache)
609607
# Acceptable clock skew for exp/nbf
610608
leeway: 60s # Configures auth_jwt_leeway
@@ -945,7 +943,7 @@ This example shows a single HTTPRoute, with a single `filter` defined in a `rule
945943

946944
Only a single `AuthenticationFilter` may be referened in a single rule.
947945

948-
The `Status` the HTTPRoute/GRPCRoute in this scenario should be set to `Invalid`, and the resource should be `Rejected`
946+
The `Status` the HTTPRoute/GRPCRoute in this scenario should be set to `Invalid`, and the resource should be `Rejected`.
949947

950948
This behaviour falls in line with the expected behaviour of filters in the Gateway API, which generally allows only one type of a specific filter (authentication, rewriting, etc.) within a rule.
951949

@@ -1043,7 +1041,6 @@ spec:
10431041
secretRef:
10441042
namespace: security-ns
10451043
name: basic-auth-users
1046-
key: htpasswd
10471044
realm: "Restricted"
10481045
```
10491046

0 commit comments

Comments
 (0)