Skip to content

Commit dd24287

Browse files
committed
Ensure no default for JWT key mode
1 parent 5ff7389 commit dd24287

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

docs/proposals/authentication-filter.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ type BasicAuth struct {
138138
// When namespace is set and differs from the filter's namespace, a ReferenceGrant in the target namespace is required.
139139
//
140140
// +optional
141-
SecretRef *NamespacedSecretKeyReference `json:"secretRef,omitempty"`
141+
SecretRef *SecretObjectReference `json:"secretRef,omitempty"`
142142

143143
// Realm used by NGINX `auth_basic`.
144144
// Configures "realm="<realm_value>" in WWW-Authenticate header in error page location.
@@ -166,9 +166,6 @@ type JWTAuth struct {
166166
Realm *string `json:"realm,omitempty"`
167167

168168
// Mode selects how JWT keys are provided: local file or remote JWKS.
169-
// Default: File.
170-
//
171-
// +kubebuilder:default=File"
172169
Mode JWTKeyMode `json:"mode,omitempty"`
173170

174171
// File specifies local JWKS configuration (Secret or ConfigMap, mount path, file name).
@@ -261,7 +258,7 @@ type JWTFileKeySource struct {
261258
// Exactly one of ConfigMapRef or SecretRef must be set.
262259
//
263260
// +optional
264-
SecretRef *NamespacedSecretKeyReference `json:"secretRef,omitempty"`
261+
SecretRef *SecretObjectReference `json:"secretRef,omitempty"`
265262

266263
// KeyCache is the cache duration for keys.
267264
// Configures `auth_jwt_key_cache` directive
@@ -611,8 +608,8 @@ spec:
611608
type: JWT
612609
jwt:
613610
realm: "Restricted"
614-
# Key verification mode: Local file or Remote JWKs
615-
mode: File # Defaults to File.
611+
# Key verification mode. Local file or Remote JWKs
612+
mode: File
616613
file:
617614
secretRef:
618615
name: jwt-keys-secure
@@ -639,7 +636,7 @@ spec:
639636
jwt:
640637
realm: "Restricted"
641638
# Key verification mode: Local file or Remote JWKs
642-
mode: Remote # Defaults to File.
639+
mode: Remote
643640
remote:
644641
url: https://issuer.example.com/.well-known/jwks.json
645642
# Acceptable clock skew for exp/nbf

0 commit comments

Comments
 (0)