[#.x] - phpcs

Author: niden

src/Domain/DataSource/User/UserTransport.php

@@ -26,7 +26,7 @@
  */
 final class UserTransport
 {
-    /** @var TUserTransport  */
+    /** @var TUserTransport */
     private array $store;
 
     /**

src/Domain/DataSource/User/UserTypes.php

@@ -13,7 +13,6 @@
 
 namespace Phalcon\Api\Domain\DataSource\User;
 
-
 /**
  * @phpstan-type TUserRecord array{}|array{
  *     usr_id: int,

src/Domain/Hello/HelloService.php

@@ -37,7 +37,7 @@ public function __invoke(array $input): Payload
             DomainStatus::SUCCESS,
             [
                 'results' => [
-                    "Hello World!!! - " . date(Dates::DATE_TIME_FORMAT)
+                    "Hello World!!! - " . date(Dates::DATE_TIME_FORMAT),
                 ],
             ]
         );

src/Domain/Services/Container.php

@@ -44,22 +44,12 @@ class Container extends Di
     public const EVENTS_MANAGER = 'eventsManager';
     /** @var string */
     public const FILTER = 'filter';
-    /** @var string */
-    public const LOGGER = 'logger';
-    /** @var string */
-    public const REQUEST = 'request';
-    /** @var string */
-    public const RESPONSE = 'response';
-    /** @var string */
-    public const ROUTER = 'router';
-    /** @var string */
-    public const TIME = 'time';
-
     /**
      * Services
      */
     public const HELLO_SERVICE    = HelloService::class;
-    public const USER_GET_SERVICE = 'service.user.get';
+    /** @var string */
+    public const LOGGER = 'logger';
     /**
      * Middleware
      */
@@ -70,10 +60,19 @@ class Container extends Di
      * Repositories
      */
     public const REPOSITORY_USER = 'repository.user';
+    /** @var string */
+    public const REQUEST = 'request';
     /**
      * Responders
      */
     public const RESPONDER_JSON = JsonResponder::class;
+    /** @var string */
+    public const RESPONSE = 'response';
+    /** @var string */
+    public const ROUTER = 'router';
+    /** @var string */
+    public const TIME = 'time';
+    public const USER_GET_SERVICE = 'service.user.get';
 
     public function __construct()
     {
@@ -101,18 +100,18 @@ private function getServiceConnection(): Service
         return new Service(
             function () {
                 /** @var string $dbName */
-                $dbName = EnvManager::get('DB_NAME','phalcon');
+                $dbName = EnvManager::get('DB_NAME', 'phalcon');
                 /** @var string $host */
-                $host   = EnvManager::get('DB_HOST','rest-db');
+                $host = EnvManager::get('DB_HOST', 'rest-db');
                 /** @var string $password */
-                $password = EnvManager::get('DB_PASS','secret');
-                $port = (int)EnvManager::get('DB_PORT',3306);
+                $password = EnvManager::get('DB_PASS', 'secret');
+                $port     = (int)EnvManager::get('DB_PORT', 3306);
                 /** @var string $username */
-                $username = EnvManager::get('DB_USER','root');
+                $username = EnvManager::get('DB_USER', 'root');
                 /** @var string $encoding */
-                $encoding = EnvManager::get('DB_CHARSET','utf8');
+                $encoding = EnvManager::get('DB_CHARSET', 'utf8');
                 $queries  = ['SET NAMES utf8mb4'];
-                $dsn = sprintf(
+                $dsn      = sprintf(
                     'mysql:host=%s;port=%s;dbname=%s;charset=%s',
                     $host,
                     $port,

tests/Fixtures/Domain/Migrations/UsersMigration.php

@@ -25,7 +25,7 @@ public function insert(
         ?string $username = null,
         ?string $password = null,
     ) {
-        $id = $id ?: 'null';
+        $id  = $id ?: 'null';
         $sql = <<<SQL
 INSERT INTO {$this->table} ( 
     usr_id, usr_status_flag, usr_username, usr_password

tests/Unit/Domain/User/UserServiceTest.php

@@ -76,30 +76,6 @@ public function testServiceEmptyUserId(): void
         $this->assertStringContainsString($expected, $actual);
     }
 
-    public function testServiceWrongUserId(): void
-    {
-        $container = new Container();
-        /** @var UserGetService $service */
-        $service = $container->get(Container::USER_GET_SERVICE);
-
-        $payload = $service->__invoke(
-            [
-                'userId' => 999999
-            ]
-        );
-
-        $expected = DomainStatus::NOT_FOUND;
-        $actual   = $payload->getStatus();
-        $this->assertSame($expected, $actual);
-
-        $actual = $payload->getResult();
-        $this->assertArrayHasKey('results', $actual);
-
-        $expected = 'Record(s) not found';
-        $actual   = $actual['results'][0];
-        $this->assertStringContainsString($expected, $actual);
-    }
-
     public function testServiceWithUserId(): void
     {
         $container = new Container();
@@ -115,7 +91,7 @@ public function testServiceWithUserId(): void
 
         $payload = $service->__invoke(
             [
-                'userId' => $userId
+                'userId' => $userId,
             ]
         );
 
@@ -146,4 +122,28 @@ public function testServiceWithUserId(): void
         $actual   = $user['password'];
         $this->assertSame($expected, $actual);
     }
+
+    public function testServiceWrongUserId(): void
+    {
+        $container = new Container();
+        /** @var UserGetService $service */
+        $service = $container->get(Container::USER_GET_SERVICE);
+
+        $payload = $service->__invoke(
+            [
+                'userId' => 999999,
+            ]
+        );
+
+        $expected = DomainStatus::NOT_FOUND;
+        $actual   = $payload->getStatus();
+        $this->assertSame($expected, $actual);
+
+        $actual = $payload->getResult();
+        $this->assertArrayHasKey('results', $actual);
+
+        $expected = 'Record(s) not found';
+        $actual   = $actual['results'][0];
+        $this->assertStringContainsString($expected, $actual);
+    }
 }