fix: convert absolute paths to relative paths for better portability

Author: bytemain

lib/utils.js

@@ -109,31 +109,37 @@ exports.makeUncompressFn = StreamClass => {
           .on('error', reject)
           .on('entry', (header, stream, next) => {
             stream.on('end', next);
+            const destFilePath = path.join(destDir, header.name);
 
             if (header.type === 'file') {
-              const fullpath = path.join(destDir, header.name);
-              mkdirp(path.dirname(fullpath), err => {
+              const dir = path.dirname(destFilePath);
+              mkdirp(dir, err => {
                 if (err) return reject(err);
 
                 entryCount++;
-                pump(stream, fs.createWriteStream(fullpath, { mode: opts.mode || header.mode }), err => {
+                pump(stream, fs.createWriteStream(destFilePath, { mode: opts.mode || header.mode }), err => {
                   if (err) return reject(err);
                   successCount++;
                   done();
                 });
               });
             } else if (header.type === 'symlink') {
-              // symlink
-              const src = path.join(destDir, header.name);
-              const target = path.resolve(path.dirname(src), header.linkname);
+              const dir = path.dirname(destFilePath);
+              const target = path.resolve(dir, header.linkname);
               entryCount++;
-              fs.symlink(target, src, err => {
+
+              mkdirp(dir, err => {
                 if (err) return reject(err);
-                successCount++;
-                stream.resume();
+
+                const relativeTarget = path.relative(dir, target);
+                fs.symlink(relativeTarget, destFilePath, err => {
+                  if (err) return reject(err);
+                  successCount++;
+                  stream.resume();
+                });
               });
             } else { // directory
-              mkdirp(path.join(destDir, header.name), err => {
+              mkdirp(destFilePath, err => {
                 if (err) return reject(err);
                 stream.resume();
               });
@@ -175,7 +181,7 @@ function normalizePath(fileName) {
   return fileName;
 }
 
-exports.stripFileName = (strip, fileName, type) => {
+function stripFileName(strip, fileName, type) {
   // before
   // node/package.json
   // node/lib/index.js
@@ -219,3 +225,5 @@ exports.stripFileName = (strip, fileName, type) => {
   strip = Math.min(strip, s.length - 1);
   return s.slice(strip).join('/') || '/';
 };
+
+exports.stripFileName = stripFileName;