-
Notifications
You must be signed in to change notification settings - Fork 124
chore: migrate from ESLint to oxlint with @eggjs/oxlint-config extension #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate from ESLint to oxlint with @eggjs/oxlint-config extension #590
Conversation
Co-authored-by: fengmk2 <[email protected]>
commit: |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 95.27% 95.27%
=======================================
Files 11 11
Lines 1377 1377
Branches 316 317 +1
=======================================
Hits 1312 1312
Misses 61 61
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…aining compatibility Co-authored-by: fengmk2 <[email protected]>
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
[skip ci] ## <small>4.8.2 (2025-08-12)</small> * fix: enumerable WellFormed ([0b1e89d](0b1e89d)) * chore: ignore pnpm-lock.yaml ([3cc8971](3cc8971)) * chore: migrate from ESLint to oxlint with @eggjs/oxlint-config extension (#590) ([1ae3fd7](1ae3fd7)), closes [#590](#590) * chore: typo fix on release task name ([54aa22a](54aa22a))
|
🎉 This PR is included in version 4.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR migrates the linting setup from ESLint to oxlint, extending from the
@eggjs/oxlint-configconfiguration package while maintaining backward compatibility.Changes Made
eslintandeslint-config-eggoxlintand@eggjs/oxlint-configeslint src test --ext .ts --cachetooxlint src test.oxlintrc.jsonthat extends from@eggjs/oxlint-configwith selective rule overrides to maintain compatibilityConfiguration Approach
The new
.oxlintrc.jsonextends from@eggjs/oxlint-configas the base configuration but selectively disables additional rules to preserve the original linting behavior. This approach:no-extend-nativerule)Performance Benefits
Before vs After
Before (ESLint):
After (oxlint with @eggjs/oxlint-config):
The migration successfully uses the official EggJS oxlint configuration while maintaining the same linting behavior for backward compatibility.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.