The http2 server throws TypeError `server.shouldUpgradeCallback` is not a function

[ShenHongFei]

Version

origin/main branch

Platform

windows "$([Environment]::OSVersion.VersionString) $(('x86', 'x64')[[Environment]::Is64BitOperatingSystem])"

Subsystem

http

What steps will reproduce the bug?

import { createSecureServer } from 'http2'

let server = createSecureServer(...)

server.on('upgrade', () => { ... })

server.listen(443)

// Create a websocket connection to port 443

How often does it reproduce? Is there a required condition?

Must appear

What is the expected behavior? Why is that the expected behavior?

Websocket connection is normal

What do you see instead?

Additional information

relates to: #59824

Can you (@pimterry) add relevant test cases for this PR? http server, http2 server and test websocket connection

[pimterry]

Thanks @ShenHongFei I'll look into this now. Can you share a complete example including the full HTTP/2 server options and the client connection code you're using? I'm a bit surprised that it's possible to hit this code path - in theory (https://developer.mozilla.org/en-US/docs/Web/HTTP/Guides/Protocol_upgrade_mechanism) upgrade shouldn't be possible in HTTP/2 at all.

[ShenHongFei]

{
    ca: ...
    allowHTTP1: true
}

[pimterry]

Should be fixed in #59924 @ShenHongFei

[ShenHongFei]

@pimterry I just merged this PR locally and tried it. It works fine without any errors. Thank you very much.

Do I need to close this issue? Or should I wait until your PR is merged?

[pimterry]

Great, thanks for testing that @ShenHongFei! Let's leave this open until a fix is fully completed, that PR will close this issue automatically once it's merged.